pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: Rural Hunter <ruralhunter@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed
Date: Mon, 24 Sep 2012 09:08:20 -0400
Message-ID: <20120924130820.GB21242@momjian.us> (raw)
In-Reply-To: <50605ABC.1000304@gmx.net>
References: <20120917043236.GA20123@momjian.us>
	<5056AF29.3040903@gmail.com>
	<20120917210723.GA30394@momjian.us>
	<20120918232239.GA2014@momjian.us>
	<505C307E.20501@gmail.com>
	<1348403628.18490.1.camel@vanquo.pezone.net>
	<505F1A98.9090901@gmail.com>
	<1348440393.18490.2.camel@vanquo.pezone.net>
	<20120924125500.GA21242@momjian.us>
	<50605ABC.1000304@gmx.net>

On Mon, Sep 24, 2012 at 09:06:04AM -0400, Peter Eisentraut wrote:
> On 9/24/12 8:55 AM, Bruce Momjian wrote:
> > I can confirm that pg_upgrade does case-insensitive comparisons of
> > encoding/locale names:
> > 
> > 	static void
> > 	check_locale_and_encoding(ControlData *oldctrl,
> > 	                          ControlData *newctrl)
> > 	{
> > 	    /* These are often defined with inconsistent case, so use pg_strcasecmp(). */
> > 	    if (pg_strcasecmp(oldctrl->lc_collate, newctrl->lc_collate) != 0)
> > 	        pg_log(PG_FATAL,
> > 	               "old and new cluster lc_collate values do not match\n");
> > 	    if (pg_strcasecmp(oldctrl->lc_ctype, newctrl->lc_ctype) != 0)
> > 	        pg_log(PG_FATAL,
> > 	               "old and new cluster lc_ctype values do not match\n");
> 
> I seem to recall that at some point in the distant past, somehow some
> Linux distributions changed the canonical spelling of locale names from
> xx_YY.UTF-8 to xx_YY.utf8.  So if people are upgrading old PostgreSQL
> instances that use the old spelling, pg_upgrade will probably fail.  A
> fix might be to take the locale name you find in pg_control and run it
> through setlocale() to get the new canonical name.

Or we could just remove dashes from the name before comparisons.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +




view thread (49+ messages)  latest in thread

Message-ID: <20120924130820.GB21242@momjian.us>
Permalink:  ../20120924130820.GB21242@momjian.us/
Also on:    postgresql.org/message-id/20120924130820.GB21242@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: bruce@momjian.us, peter_e@gmx.net, ruralhunter@gmail.com, pgsql-hackers@postgresql.org, tgl@sss.pgh.pa.us
  Subject: Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed
  In-Reply-To: <20120924130820.GB21242@momjian.us>
  References: <20120917043236.GA20123@momjian.us> <5056AF29.3040903@gmail.com> <20120917210723.GA30394@momjian.us> <20120918232239.GA2014@momjian.us> <505C307E.20501@gmail.com> <1348403628.18490.1.camel@vanquo.pezone.net> <505F1A98.9090901@gmail.com> <1348440393.18490.2.camel@vanquo.pezone.net> <20120924125500.GA21242@momjian.us> <50605ABC.1000304@gmx.net> <20120924130820.GB21242@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox