From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Terry Phelps <tgphelps50@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Compile error while building postgresql 10.3
Date: Mon, 19 Mar 2018 12:54:51 -0700
Message-ID: <20180319195451.vxymrucrnxwpbzw3@alap3.anarazel.de> (raw)
In-Reply-To: <28853.1521489010@sss.pgh.pa.us>
References: <CAMUfR_vJKnd6oCA28petJ5NFTVyt99xxAEz1PS1zKErhtMc-fw@mail.gmail.com>
<13506.1521487746@sss.pgh.pa.us>
<CAMUfR_t8h7ZUmMu2bHvkgwG1F6JLdnMjHkrjMnuA4jevKTWpQw@mail.gmail.com>
<28853.1521489010@sss.pgh.pa.us>
On 2018-03-19 15:50:10 -0400, Tom Lane wrote:
> [ please keep the list cc'd ]
>
> Terry Phelps <tgphelps50@gmail.com> writes:
> > I can barely read a configure.in file, but here's what I think you're
> > asking for. If not, I'll try again:
>
> > configure:15453: checking for _mm_crc32_u8 and _mm_crc32_u32 with
> > CFLAGS=-msse4.2
> > configure:15475: cc -o conftest -Wall -Wmissing-prototypes -Wpointer-arith
> > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute
> > -Wformat-security -fno-strict-aliasing -fwrapv
> > -Wno-unused-command-line-argument -I/usr/local/include -msse4.2
> > -L/usr/local/lib conftest.c -lz -lreadline -lcrypt -lm >&5
> > configure:15475: $? = 0
> > configure:15484: result: yes
>
> Interesting. So it looks like configure *did* decide that -msse4.2
> is needed. What do you get from "grep sse4 src/Makefile.global" ?
> What I'd expect is
>
> CFLAGS_SSE42 = -msse4.2
> PG_CRC32C_OBJS = pg_crc32c_sse42.o pg_crc32c_sb8.o pg_crc32c_choose.o
>
> If you see that, then the next question is why CFLAGS_SSE42 isn't
> getting propagated into the build of pg_crc32c_sse42.o, which would
> seem to suggest a problem with gmake. What make version are you
> using?
There seems to be something sketchy afoot here, even outside of
CFLAGS_SSE42 itself. From the original email:
cc -I/usr/local/include -I../../src/port -DFRONTEND -I../../src/include
-c -o pg_crc32c_sse42.o pg_crc32c_sse42.c
isn't this missing a number of important flags? Like at least
-fno-strict-aliasing -fwrapv -fexcess-precision=standard?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-admin@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, tgphelps50@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Compile error while building postgresql 10.3
In-Reply-To: <20180319195451.vxymrucrnxwpbzw3@alap3.anarazel.de>
References: <CAMUfR_vJKnd6oCA28petJ5NFTVyt99xxAEz1PS1zKErhtMc-fw@mail.gmail.com> <13506.1521487746@sss.pgh.pa.us> <CAMUfR_t8h7ZUmMu2bHvkgwG1F6JLdnMjHkrjMnuA4jevKTWpQw@mail.gmail.com> <28853.1521489010@sss.pgh.pa.us> <20180319195451.vxymrucrnxwpbzw3@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox