pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Scott Ribe <scott_ribe@elevated-dev.com>
Cc: Pgsql-admin <pgsql-admin@lists.postgresql.org>
Subject: Re: 12 to 13 migration, the privs error with pg_pltemplate
Date: Fri, 18 Dec 2020 11:19:15 -0500
Message-ID: <20201218161915.GC16415@tamriel.snowman.net> (raw)
In-Reply-To: <107286.1608231011@sss.pgh.pa.us>
References: <074FE83A-E924-4787-9E68-27EB9CE142B3@elevated-dev.com>
	<3264512.1607456932@sss.pgh.pa.us>
	<154608A6-0F38-4BE8-B3F4-3E3308691F91@elevated-dev.com>
	<2BD26D52-19B8-42CD-860D-B9AE21AF5C61@elevated-dev.com>
	<3632844.1607534358@sss.pgh.pa.us>
	<20201217184017.GA23245@momjian.us>
	<107286.1608231011@sss.pgh.pa.us>

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Wed, Dec  9, 2020 at 12:19:18PM -0500, Tom Lane wrote:
> >> Ah, I'm sorry, I pointed you at the wrong catalog entirely.  It's
> >> not pg_default_acl that controls this, it's pg_init_privs.  I believe
> >> what pg_dump is doing is emitting GRANT commands that replicate
> >> the difference between pg_pltemplate's current actual privileges and
> >> what is shown for it in pg_init_privs.  So you need to make those
> >> two things match, in whichever way is easiest.
> 
> > Should pg_dump or pg_upgrade be detecting and reporting these things,
> > rather than requiring this analysis by the user?
> 
> It's a little premature to be considering that when we still haven't
> identified exactly what the problem is.

Pretty sure we did get to the bottom of it, the OP was just in the wrong
database.

Anastasia, as I recall, had a patch that worked to avoid dumping out
privileges and such for things which disappeared but I don't think
anyone ended up finding time to review and commit it.  I do think that,
in general, that was a good effort though and it'd be nice to get it (or
something like it) committed to avoid having this issue for users who
have GRANT'd rights to pg_catalog tables that are later changed between
versions.

Thanks,

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (25+ messages)

Message-ID: <20201218161915.GC16415@tamriel.snowman.net>
Permalink:  ../20201218161915.GC16415@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20201218161915.GC16415@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, bruce@momjian.us, scott_ribe@elevated-dev.com, pgsql-admin@lists.postgresql.org
  Subject: Re: 12 to 13 migration, the privs error with pg_pltemplate
  In-Reply-To: <20201218161915.GC16415@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox