pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Don Seiler <don@seiler.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Estimating HugePages Requirements?
Date: Mon, 14 Mar 2022 10:34:17 -0700
Message-ID: <20220314173417.GA1020555@nathanxps13> (raw)
In-Reply-To: <CABUevEweO_ZxTQox=QoO8e3rZQm9qFVU+zdoQvazTH9F7HpdEQ@mail.gmail.com>
References: <89EFD5FB-3C28-459C-9D6D-C9F93F7C2A54@amazon.com>
	<YTbjyHkTa2xBdzgf@paquier.xyz>
	<578A8F79-FD13-4408-865F-4D31EE5D8123@amazon.com>
	<YTgy8PdP1+9s6NBz@paquier.xyz>
	<4cc5b434-b174-9aae-197b-737db6cac4e3@oss.nttdata.com>
	<C35CB94F-D391-4E52-AB08-A726112FA852@amazon.com>
	<YTmLQtpUSK77mlGT@paquier.xyz>
	<YTmMLtoLEAjMuRSm@paquier.xyz>
	<6AE0285D-0917-4C05-B6AA-4AEDD2FCBA52@amazon.com>
	<CABUevEweO_ZxTQox=QoO8e3rZQm9qFVU+zdoQvazTH9F7HpdEQ@mail.gmail.com>

On Mon, Mar 14, 2022 at 04:26:43PM +0100, Magnus Hagander wrote:
> Nothing fixing this ended up actually getting committed, right? That
> is, we still get the extra log output?

Correct.

> And in fact, the command documented on
> https://www.postgresql.org/docs/devel/kernel-resources.html doesn't
> actually produce the output that the docs show, it also shows the log
> line, in the default config? If we can't fix the extra logging we
> should at least have our docs represent reality -- maybe by adding a
> "2>/dev/null" entry? But it'd be better to have it not output that log
> in the first place...

I attached a patch to adjust the documentation for now.  This apparently
crossed my mind earlier [0], but I didn't follow through with it for some
reason.

> (Of course what I'd really want is to be able to run it on a cluster
> that's running, but that was discussed downthread so I'm not bringing
> that one up for changes now)

I think it is worth revisiting the extra logging and the ability to view
runtime-computed GUCs on a running server.  Should this be an open item for
v15, or do you think it's alright to leave it for the v16 development
cycle?

[0] https://postgr.es/m/C45224E1-29C8-414C-A8E6-B718C07ACB94%40amazon.com

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachments:

  v1-0001-send-stderr-to-dev-null-in-Linux-Huge-Pages-docum.patch (text/x-diff, 0B) download

view thread (108+ messages)  latest in thread

Message-ID: <20220314173417.GA1020555@nathanxps13>
Permalink:  ../20220314173417.GA1020555@nathanxps13/
Also on:    postgresql.org/message-id/20220314173417.GA1020555@nathanxps13

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: nathandbossart@gmail.com, magnus@hagander.net, bossartn@amazon.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, andres@anarazel.de, mark.dilger@enterprisedb.com, don@seiler.us, pgsql-hackers@postgresql.org
  Subject: Re: Estimating HugePages Requirements?
  In-Reply-To: <20220314173417.GA1020555@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox