pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: andy <andy@squeakycode.net>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [ADMIN] Vacuum error on database postgres
Date: Thu, 14 Sep 2006 11:20:30 -0400
Message-ID: <29469.1158247230@sss.pgh.pa.us> (raw)
In-Reply-To: <45095CDD.8090704@squeakycode.net>
References: <44F82150.5000809@pnlassociates.com>
	<4001.1157121669@sss.pgh.pa.us>
	<ee7pua$2bou$1@news.hub.org>
	<27602.1158238299@sss.pgh.pa.us>
	<45095CDD.8090704@squeakycode.net>

andy <andy@squeakycode.net> writes:
> Tom Lane wrote:
>> andy <andy@squeakycode.net> writes:
>>> So I'm ok, but I tried it again, by dropping the database and re-running 
>>> both scripts and got the same error again.  So thought I'd offer a test 
>>> case if there was interest.
>> 
>> Absolutely.  I've seen just enough of these reports to make me think
>> there's an underlying bug.

> Here are some urls: ...

Doh ... I think the critical bit is here:

autovacuum = on                 # enable autovacuum subprocess?

The problem is that ANALYZE takes only AccessShareLock on a table,
so it's entirely possible for two backends to try to ANALYZE the
same table concurrently, and in particular for autovacuum to try to
do so while your foreground VACUUM ANALYZE is running.  That leads
to concurrent insertion attempts into pg_statistic for the same key.

This behavior dates from a time when there was no good alternative.
One possible fix today would be to make ANALYZE take
ShareUpdateExclusive lock instead, thus ensuring there is only one
ANALYZE at a time on a table.  However I'm a bit concerned by the
possibility that ANALYZE-inside-a-transaction could accumulate a
whole bunch of such locks in a random order, leading at least to
a risk of deadlocks against other ANALYZEs.  (We have to hold the
lock till commit, else we aren't fixing the problem.)  Do we need a
specialized lock type just for ANALYZE?  Would sorting the target
list of rel OIDs be enough?  Perhaps it's not worth worrying about?

			regards, tom lane



view thread (21+ messages)  latest in thread

Message-ID: <29469.1158247230@sss.pgh.pa.us>
Permalink:  ../29469.1158247230@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/29469.1158247230@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andy@squeakycode.net, alvherre@alvh.no-ip.org, pgsql-hackers@postgreSQL.org
  Subject: Re: [ADMIN] Vacuum error on database postgres
  In-Reply-To: <29469.1158247230@sss.pgh.pa.us>
  References: <44F82150.5000809@pnlassociates.com> <4001.1157121669@sss.pgh.pa.us> <ee7pua$2bou$1@news.hub.org> <27602.1158238299@sss.pgh.pa.us> <45095CDD.8090704@squeakycode.net> <29469.1158247230@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox