pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Teodor Sigaev <teodor@sigaev.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Craig McElroy <craig.mcelroy@contegix.com>
Cc: PostgreSQL Admin List <pgsql-admin@postgresql.org>
Subject: Re: Problem with PITR Past Particular WAL File
Date: Thu, 25 Oct 2007 22:05:45 +0400
Message-ID: <4720DAF9.6080002@sigaev.ru> (raw)
In-Reply-To: <16979.1193327974@sss.pgh.pa.us>
References: <FF045AC2-D3E0-4DC6-BE39-4925AE9AD804@contegix.com>
	<10123.1193250394@sss.pgh.pa.us>
	<1FAEADD9-FE4A-444E-9B45-D6192B0265E5@contegix.com>
	<16979.1193327974@sss.pgh.pa.us>

>> #0  0x080b8ee0 in entrySplitPage ()
>> #1  0x080baccf in ginInsertValue ()
Corrupted stack? gin_xlog_cleanup() doesn't call ginInsertValue() directly.

>> #2  0x080b81b7 in gin_xlog_cleanup ()
>> #3  0x080af4ce in StartupXLOG ()
>> #4  0x080c04ca in BootstrapMain ()
>> #5  0x08186b2f in StartChildProcess ()
>> #6  0x081889eb in PostmasterMain ()
>> #7  0x0814ee9e in main ()

> Teodor, can you comment on whether this stack trace looks like it could
> be related to that fix?
No, I suppose. That changes was about deadlock prevention, recognize splits and
fixes in deletion of page in a posting tree. entrySplitPage() is a split of page 
of indexed values.

Hmm. I suppose, I found a reason. Real backtrace should look like:
  gin_xlog_cleanup()
	ginContinueSplit()
		prepareEntryScan(,,,NULL) // makes btree.ginstate = NULL
		ginInsertValue()
			entrySplitPage() // tries to access
					 // btree->ginstate->tupdesc in
					 // 497 line


That piece of code:
     value = index_getattr(leftrightmost, FirstOffsetNumber, 
btree->ginstate->tupdesc, &isnull);
     btree->entry = GinFormTuple(btree->ginstate, value, NULL, 0);
     ItemPointerSet(&(btree->entry)->t_tid, BufferGetBlockNumber(lbuf), 
InvalidOffsetNumber);

It just makes new tuple with the same value and another ItemPointer. Some later 
I'll make a patch which will not call index_getattr() and GinFormTuple() - now I 
know how make a test suite.

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/



view thread (14+ messages)  latest in thread

Message-ID: <4720DAF9.6080002@sigaev.ru>
Permalink:  ../4720DAF9.6080002@sigaev.ru/
Also on:    postgresql.org/message-id/4720DAF9.6080002@sigaev.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: teodor@sigaev.ru, tgl@sss.pgh.pa.us, craig.mcelroy@contegix.com
  Subject: Re: Problem with PITR Past Particular WAL File
  In-Reply-To: <4720DAF9.6080002@sigaev.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox