From: Guillaume Lelarge <guillaume@lelarge.info>
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Cc: Kasia Tuszynska <ktuszynska@esri.com>
Subject: Re: [ADMIN] two questions about pg 9.0
Date: Sat, 16 Oct 2010 00:23:57 +0200
Message-ID: <4CB8D47D.7070804@lelarge.info> (raw)
In-Reply-To: <4CB6DCF1.5060006@lelarge.info>
References: <1508171717.69491.1286831195955.JavaMail.root@sz0093a.westchester.pa.mail.comcast.net>
<7815.1286839244@sss.pgh.pa.us>
<232B5217AD58584C87019E8933556D1102198CA98C@redmx2.esri.com>
<4CB4A1F9.60408@lelarge.info>
<232B5217AD58584C87019E8933556D1102199CC548@redmx2.esri.com>
<4CB62282.1070408@lelarge.info>
<4CB6DCF1.5060006@lelarge.info>
Le 14/10/2010 12:35, Guillaume Lelarge a écrit :
> Le 13/10/2010 23:20, Guillaume Lelarge a écrit :
>> Le 13/10/2010 22:21, Kasia Tuszynska a écrit :
>>> [...]
>>> Thanks for your reply I did a bit more testing with the superuser priv issue, and now I came to the conclusion that pgAdminIII may be doing something silly.
>>>
>>
>> Sure, that happens more than I would like.
>>
>>> I created a user: bob
>>>
>>> In pgAdminIII I checked off the box for: can inherit from parent role, can create db object, superuser
>>> Got the following sql:
>>> CREATE ROLE bob LOGIN
>>> ENCRYPTED PASSWORD 'md51e9484aace238e7cb2609130fd87646e'
>>> SUPERUSER INHERIT CREATEDB NOCREATEROLE;
>>> UPDATE pg_authid SET rolcapupdate=false WHERE rolname='bob';
>>>
>>> Than I created bobb
>>> In pgAdminIII I checked off the box for: can inherit from parent role, can create db object, superuser, Can modify catalog directly
>>> Got the following sql:
>>> CREATE ROLE bobb LOGIN
>>> ENCRYPTED PASSWORD 'md51e9484aace238e7cb2609130fd87646e'
>>> SUPERUSER INHERIT CREATEDB NOCREATEROLE;
>>>
>>> Conclusion:
>>> Sql level superuser = pgAdminIII superuser + can modify catalog directly
>>>
>>> This is misleading, I would call it a pgAdminIII bug but who knows maybe it is a feature...
>>>
>>
>> I would not call it a feature. I find this misleading too. I'm too tired
>> right now to work on a fix, but it'll be easy and quick to do.
>>
>> I have a few things to commit tomorrow. I'll try to work on this at the
>> same time.
>>
>
> OK, was really simple to fix. See the patch attached.
>
> Any comments on this patch? I'm ready to commit it on 1.12 and master,
> if no-one objects.
>
Commited.
--
Guillaume
http://www.postgresql.frhttp://dalibo.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: guillaume@lelarge.info, pgadmin-hackers@postgresql.org, ktuszynska@esri.com
Subject: Re: [ADMIN] two questions about pg 9.0
In-Reply-To: <4CB8D47D.7070804@lelarge.info>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox