From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Date: Fri, 08 May 2015 20:37:15 +0300
Message-ID: <554CF44B.3080808@iki.fi> (raw)
In-Reply-To: <10633.1431105922@sss.pgh.pa.us>
References: <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com>
<20150508150340.GJ12950@alap3.anarazel.de>
<9096.1431102730@sss.pgh.pa.us>
<20150508165246.GO12950@alap3.anarazel.de>
<10633.1431105922@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 05/08/2015 08:25 PM, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2015-05-08 12:32:10 -0400, Tom Lane wrote:
>>> Looks like there's a CLOBBER_CACHE_ALWAYS issue ...
>>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguarundi&dt=2015-05-08%2011%3A52%3A00
>
>> Currently index inferrence ignores indexes that aren't yet valid
>> according to checkxmin. I'm tempted to think that is a mistake. I think
>> we should throw an error instead; possbily at execution rather than plan
>> time.
>
> If that's what is happening, then throwing an error is not going to fix
> the problem of the regression test results being unstable; it'll just be
> a different error that might or might not get thrown depending on timing.
Why does INSERT ON CONFLICT pay attention to indcheckxmin? Uniqueness
check only cares about the most recent committed version of the tuple,
and the index good for that use immediately. If there was a problem
there, the uniqueness check in a normal insert have the same problem.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: hlinnaka@iki.fi, tgl@sss.pgh.pa.us, andres@anarazel.de, pg@heroku.com, jeff.janes@gmail.com, sfrost@snowman.net, dean.a.rasheed@gmail.com, bruce@momjian.us, pgsql-hackers@postgresql.org
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
In-Reply-To: <554CF44B.3080808@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox