pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgreSQL.org
Subject: Implicit casting for || (was Re: grant execute on many functions)
Date: Wed, 30 Jun 2004 09:47:56 -0400
Message-ID: <8120.1088603276@sss.pgh.pa.us> (raw)
In-Reply-To: <40E24C15.4040901@joeconway.com>
References: <40E1E1A9.8080207@fastmail.fm>
	<40E1ECEF.5090007@joeconway.com>
	<3318.1088567114@sss.pgh.pa.us>
	<40E23F72.4000108@joeconway.com>
	<3843.1088570281@sss.pgh.pa.us>
	<40E24C15.4040901@joeconway.com>

[ moving thread to a more appropriate list ]

Joe Conway <mail@joeconway.com> writes:
> Tom Lane wrote:
>> select 'GRANT EXECUTE ON ' || 1142::regprocedure;
>> ERROR:  array value must start with "{" or dimension information
>> 
>> BTW, it seems like there's something pretty broken here.  How did
>> arrays get into it?

> regression=# \df array_append
>                            List of functions
>   Result data type |   Schema   |     Name     | Argument data types
> -------------------+------------+--------------+----------------------
>   anyarray         | pg_catalog | array_append | anyarray, anyelement
> (1 row)

> So the "||" operator sees (unknown, regprocedure), and make_op tries to 
> coerce the unknown literal to an array of regprocedure, which of course 
> fails. If instead the literal is explicitly cast:

> select 'GRANT EXECUTE ON '::text || 1142::regprocedure;
> ERROR:  operator does not exist: text || regprocedure
> HINT:  No operator matches the given name and argument type(s). You may 
> need to add explicit type casts.

> I'm not clear on how we can do better :(. Any suggestions?

I'm not sure either, but I can't say that I like this interpretation.
I did find that if there is an implicit coercion to text then the system
will prefer a saner interpretation:

regression=# select 'GRANT EXECUTE ON ' || 1142::regprocedure;
ERROR:  array value must start with "{" or dimension information

regression=# create function text(regprocedure) returns text as '
regression'# begin
regression'#   return $1;
regression'# end' language plpgsql stable strict;
CREATE FUNCTION
regression=# create cast (regprocedure as text) with function text(regprocedure) as implicit;
CREATE CAST

regression=# select 'GRANT EXECUTE ON ' || 1142::regprocedure;
                ?column?
-----------------------------------------
 GRANT EXECUTE ON date_mii(date,integer)
(1 row)

I'm worried though about how stable this choice is.  I'm almost tempted
to add a wart in the coercion routines to discourage matching "unknown"
to "anyarray" ...

			regards, tom lane



Message-ID: <8120.1088603276@sss.pgh.pa.us>
Permalink:  ../8120.1088603276@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8120.1088603276@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mail@joeconway.com, pgsql-hackers@postgreSQL.org
  Subject: Re: Implicit casting for || (was Re: grant execute on many functions)
  In-Reply-To: <8120.1088603276@sss.pgh.pa.us>
  References: <40E1E1A9.8080207@fastmail.fm> <40E1ECEF.5090007@joeconway.com> <3318.1088567114@sss.pgh.pa.us> <40E23F72.4000108@joeconway.com> <3843.1088570281@sss.pgh.pa.us> <40E24C15.4040901@joeconway.com> <8120.1088603276@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox