pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Mario De Frutos Dieguez <mariodefrutos@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Fwd: Problem with a "complex" upsert
Date: Fri, 03 Aug 2018 18:58:39 -0400
Message-ID: <8968.1533337119@sss.pgh.pa.us> (raw)
In-Reply-To: <20180803224455.4g2hnvciynu2s7iv@alap3.anarazel.de>
References: <CAFYwGJ3Cpb2T+177rEopU7_aQE3W03UoqNZXdP5erCtSRgDGVA@mail.gmail.com>
	<18795.1529600753@sss.pgh.pa.us>
	<8da3739d-da24-1125-cab6-b68d6ec1bc6a@lab.ntt.co.jp>
	<30415.1531256373@sss.pgh.pa.us>
	<4b956567-8283-1b8a-7cd7-f8b6e626bba9@lab.ntt.co.jp>
	<CAEZATCWqLba_VVT1cdaT3YOijESRT8qewLN93Oc7H7ikW2fd-Q@mail.gmail.com>
	<CAEZATCUzdUerONYpaZ-YTVKOyzm1B-Ya9XzFXoMs0yrwJr0hkw@mail.gmail.com>
	<20180803184638.gdii7mja7qfc3fba@alap3.anarazel.de>
	<CAEZATCViZQcByymBpdWY2pXKHpvoX4ZN+G+KhAMEi=w3fwRnDA@mail.gmail.com>
	<7664.1533335577@sss.pgh.pa.us>
	<20180803224455.4g2hnvciynu2s7iv@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-08-03 18:32:57 -0400, Tom Lane wrote:
>> Balance the risks of shipping a broken release vs. waiting one
>> more quarter to ship the fix.  After a quick look at the size
>> of the patch, my own inclination if I were the committer would
>> be to wait till after the releases are out.  Or you might
>> consider pushing only to 11+HEAD, with the expectation of
>> back-patching later after we've gotten some beta results.

> This results in clearly inserting wrong data and/or crashing the
> server. And it's not a huge effect outside of already broken scenarios.
> I think we definitely should try to get this in.

Well, if you're excited about it, help Dean review it.  My own feeling
is that this case has been broken for several years with no one noticing,
so it can't be all that critical.

			regards, tom lane




view thread (30+ messages)  latest in thread

Message-ID: <8968.1533337119@sss.pgh.pa.us>
Permalink:  ../8968.1533337119@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8968.1533337119@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, dean.a.rasheed@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, mariodefrutos@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Fwd: Problem with a "complex" upsert
  In-Reply-To: <8968.1533337119@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox