public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Atkinson <[email protected]>
To: Adrian Klaver <[email protected]>
Cc: Jonathan S. Katz <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Advocacy <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: PostgreSQL 17 release announcement draft
Date: Fri, 6 Sep 2024 13:02:15 -0500
Message-ID: <CAG6XLEk4=W5VLSuNj9p3uq=R=-aizR8P8d4EhVZmjsnE6kGUFg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<CA+TgmobUY2Ca-+BEbyi0Bgmc5TGDjXH=YhXAZmaKkyp+8CCuoA@mail.gmail.com>
<CAG6XLEnr9QrQF==Sry7o_Y5SkcengQTCwEeJLYg_=FM2D65ukw@mail.gmail.com>
<CAG6XLEnFqpKERsw=0xM9W3QGyifR6K8epHzUtedESDHtOq8p8A@mail.gmail.com>
<CAG6XLE=H4W4g_ZzTk-qotsiyFLTcRRGUghY-0gDutQj9L_6jDQ@mail.gmail.com>
<CAG6XLEk19rgUWarFbO2uq55gkvwRPMYEFXrWKgM5zyp8BACgZg@mail.gmail.com>
<[email protected]>
<[email protected]>
This is looking crisper. Nice edits! I did one more read through and have
minor comments and suggestions.
----------------------
> "PostgreSQL 17 introduces a new internal memory structure for vacuum
was used that consumes up to 20x less memory"
Small typo, I think "that" was missed:
PostgreSQL 17 introduces a new internal memory structure for vacuum that
consumes up to 20x less memory.
----------------------
> "and PostgreSQL 17 adds to its implementation SQL/JSON standard."
is this missing "of the" ?
and PostgreSQL 17 adds to its implementation "of" the SQL/JSON standard.
----------------------
"exporting,including"
add space after "exporting", assuming this was copied correctly from the
source file into google docs (which it may not have been) :)
----------------------
This is in the realm of personal preference/suggestion. The word
"federated" is complex and I kind of understand it, but prefer simpler
terminology. Here's a suggestion:
"This release expands on functionality for managing data in partitions or
federated on remote PostgreSQL instances."
Alternative: "This release expands on functionality for managing data in
partitions or data spread out between local and remote PostgreSQL
instances."
----------------------
Suggestion: both "converts" and "creates" verbs are used in the docs
to describe pg_createsubscriber. I like the verb "convert" because I think
it speaks more to the purpose of being run on a physical replica, then
turning it into a logical replication based instance as a subscriber.
With that said, my suggested alternative is:
PostgreSQL 17 introduces the
[`pg_createsubscriber`](
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
<https://www.google.com/url?q=https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html&sa=D...;
)
command-line tool which can be used to convert a physical replica into a
logical replica.
----------------------
> "which allows you to give users permission to execute maintenance
operations."
Suggested simplifications:
which gives users the permissions needed to perform maintenance operations.
which provides permissions for maintenance operations.
----------------------
> "the [`pg_combinebackup`](
https://www.postgresql.org/docs/17/app-pgcombinebackup.html
<https://www.google.com/url?q=https://www.postgresql.org/docs/17/app-pgcombinebackup.html&sa=D&am...;
)
or the backup restoration process"
I thought the "or" here was maybe a mistake. Maybe it was meant to be "of".
With that said, I pulled in the verb "reconstruct" the docs use. It's a fun
verb and I know it coudl be translated to Spanish as reconstruir :)
Suggestion:
the [`pg_combinebackup`](
https://www.postgresql.org/docs/17/app-pgcombinebackup.html
<https://www.google.com/url?q=https://www.postgresql.org/docs/17/app-pgcombinebackup.html&sa=D&am...;
)
tool to reconstruct a full backup.
----------------------
> "reports the [progress of vacuuming indexes](
https://www.postgresql.org/docs/17/progress-reporting.html#VACUUM-PROGRESS-REPORTING
<https://www.google.com/url?q=https://www.postgresql.org/docs/17/progress-reporting.html%23VACUUM-PRO...;
),
and adds the [`pg_wait_events`](
https://www.postgresql.org/docs/17/view-pg-wait-events.html
<https://www.google.com/url?q=https://www.postgresql.org/docs/17/view-pg-wait-events.html&sa=D&am...;
)
For the system views, is the standard to refer to them without using the
words system view? If so, it's fine here. If not, I think it's missing that.
Suggestion: "adds the `pg_wait_events` system view" (or "view")
----------------------
"Many other new features and improvements have been added to PostgreSQL 17.
Many
of these may also be helpful for your use cases."
Recommend consolidating these two sentences.
----------------------
"## Licence" is the british english spelling intended here?
----------------------
Looks great! I even learned about more new features in this revised
version! I checked the links and saw "17" everywhere I'd expect to see it.
On Fri, Sep 6, 2024 at 12:28 PM Adrian Klaver <[email protected]>
wrote:
>
>
> On 9/6/24 10:03 AM, Jonathan S. Katz wrote:
> > On 9/5/24 3:21 PM, Andrew Atkinson wrote:
>
> > Please see v2 attached. As per original note, please provide feedback
> > before Mon, Sep 9 @ 12:00 UTC so we can begin the translation process.
>
> A quick read through found:
>
> "... the
> [`pg_combinebackup`](
> https://www.postgresql.org/docs/17/app-pgcombinebackup.html)
>
> or the backup restoration process."
>
> I'm guessing that is "... for the backup restoration process."
>
> >
> > Thanks,
> >
> > Jonathan
>
> --
> Adrian Klaver
> [email protected]
>
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: PostgreSQL 17 release announcement draft
In-Reply-To: <CAG6XLEk4=W5VLSuNj9p3uq=R=-aizR8P8d4EhVZmjsnE6kGUFg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox