pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #16645: pg_upgrade does not mark template1 as a system database
5+ messages / 3 participants
[nested] [flat]
* BUG #16645: pg_upgrade does not mark template1 as a system database
@ 2020-09-30 01:50 PG Bug reporting form <noreply@postgresql.org>
2020-09-30 02:45 ` Re: BUG #16645: pg_upgrade does not mark template1 as a system database Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: PG Bug reporting form @ 2020-09-30 01:50 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: nakagawa@goodf.co.jp
The following bug has been logged on the website:
Bug reference: 16645
Logged by: Y. NAKAGAWA
Email address: nakagawa@goodf.co.jp
PostgreSQL version: 13.0
Operating system: Windows 10 64bit
Description:
Repro steps:
1. Install postgresql-12.4-1-windows-x64.exe and
postgresql-13.0-1-windows-x64.exe.
2. Edit pg_hba.conf's on both servers to be able to connect to the servers
without password.
3. Open command prompt with administrator privilege and type:
cd %HOMEDRIVE%%HOMEPATH%
"C:\Program Files\PostgreSQL\13\bin\pg_upgrade.exe" -d "C:\Program
Files\PostgreSQL\12\data" -D "C:\Program Files\PostgreSQL\13\data" -b
"C:\Program Files\PostgreSQL\12\bin" -B "C:\Program Files\PostgreSQL\13\bin"
-U postgres
4. Open pgAdmin 4, connect to the PostgreSQL 13.0 server and expand the
Databases node.
Expected result:
The node has [postgres].
Actual result:
The node has [postgres] and [template1].
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: BUG #16645: pg_upgrade does not mark template1 as a system database
2020-09-30 01:50 BUG #16645: pg_upgrade does not mark template1 as a system database PG Bug reporting form <noreply@postgresql.org>
@ 2020-09-30 02:45 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-09-30 04:11 ` RE: BUG #16645: pg_upgrade does not mark template1 as a system database Y. NAKAGAWA <nakagawa@goodf.co.jp>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2020-09-30 02:45 UTC (permalink / raw)
To: nakagawa@goodf.co.jp; +Cc: pgsql-bugs@lists.postgresql.org
PG Bug reporting form <noreply@postgresql.org> writes:
> 4. Open pgAdmin 4, connect to the PostgreSQL 13.0 server and expand the
> Databases node.
> Expected result:
> The node has [postgres].
> Actual result:
> The node has [postgres] and [template1].
There's no particular concept of a "system database" in Postgres,
so I don't know what pgadmin is doing to decide which databases
to show or not show, but evidently it's not too well thought out.
(The closest concept I can think of is whether a DB is marked
datistemplate, but a test confirms that pg_upgrade successfully
preserves that property on template0 and template1.)
I'd suggest you file this complaint on the pgadmin lists.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* RE: BUG #16645: pg_upgrade does not mark template1 as a system database
2020-09-30 01:50 BUG #16645: pg_upgrade does not mark template1 as a system database PG Bug reporting form <noreply@postgresql.org>
2020-09-30 02:45 ` Re: BUG #16645: pg_upgrade does not mark template1 as a system database Tom Lane <tgl@sss.pgh.pa.us>
@ 2020-09-30 04:11 ` Y. NAKAGAWA <nakagawa@goodf.co.jp>
2020-10-06 09:44 ` RE: BUG #16645: pg_upgrade does not mark template1 as a system database Y. NAKAGAWA <nakagawa@goodf.co.jp>
0 siblings, 1 reply; 5+ messages in thread
From: Y. NAKAGAWA @ 2020-09-30 04:11 UTC (permalink / raw)
To: 'Tom Lane' <tgl@sss.pgh.pa.us>; +Cc: pgsql-bugs@lists.postgresql.org
Thank you for your suggestion.
According to pgAdmin4, [System database?] is [No] and [Template?] is [Yes].
I will post this to the pgadmin lists later.
Regards,
--
Nakagawa, Y.
-----Original Message-----
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Wednesday, September 30, 2020 11:46 AM
To: nakagawa@goodf.co.jp
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16645: pg_upgrade does not mark template1 as a system
database
PG Bug reporting form <noreply@postgresql.org> writes:
> 4. Open pgAdmin 4, connect to the PostgreSQL 13.0 server and expand
> the Databases node.
> Expected result:
> The node has [postgres].
> Actual result:
> The node has [postgres] and [template1].
There's no particular concept of a "system database" in Postgres, so I don't
know what pgadmin is doing to decide which databases to show or not show,
but evidently it's not too well thought out.
(The closest concept I can think of is whether a DB is marked datistemplate,
but a test confirms that pg_upgrade successfully preserves that property on
template0 and template1.)
I'd suggest you file this complaint on the pgadmin lists.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* RE: BUG #16645: pg_upgrade does not mark template1 as a system database
2020-09-30 01:50 BUG #16645: pg_upgrade does not mark template1 as a system database PG Bug reporting form <noreply@postgresql.org>
2020-09-30 02:45 ` Re: BUG #16645: pg_upgrade does not mark template1 as a system database Tom Lane <tgl@sss.pgh.pa.us>
2020-09-30 04:11 ` RE: BUG #16645: pg_upgrade does not mark template1 as a system database Y. NAKAGAWA <nakagawa@goodf.co.jp>
@ 2020-10-06 09:44 ` Y. NAKAGAWA <nakagawa@goodf.co.jp>
2020-10-06 13:55 ` Re: BUG #16645: pg_upgrade does not mark template1 as a system database Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 5+ messages in thread
From: Y. NAKAGAWA @ 2020-10-06 09:44 UTC (permalink / raw)
To: 'Tom Lane' <tgl@sss.pgh.pa.us>; +Cc: pgsql-bugs@lists.postgresql.org
I had created a ticket #5875 on pgAdmin 4 redmine.
However, after some grep-ing on pgAdmin4 source tree, I found that [System
Database?] shows pg_database.oid <= pg_database.datlastsysoid.
pg_database:
on initdb-ed 12.4:
oid datname datlastsysoid
1 template1 13317
13317 template0 13317
13318 postgres 13317
on pg_upgrade-d 13.0:
oid datname datlastsysoid
13441 template0 13441
16400 template1 13441
16401 postgres 13441
Are these differences by design?
Regards,
--
Y. Nakagawa
-----Original Message-----
From: Y. NAKAGAWA <nakagawa@goodf.co.jp>
Sent: Wednesday, September 30, 2020 1:11 PM
To: 'Tom Lane' <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: RE: BUG #16645: pg_upgrade does not mark template1 as a system
database
Thank you for your suggestion.
According to pgAdmin4, [System database?] is [No] and [Template?] is [Yes].
I will post this to the pgadmin lists later.
Regards,
--
Nakagawa, Y.
-----Original Message-----
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Wednesday, September 30, 2020 11:46 AM
To: nakagawa@goodf.co.jp
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16645: pg_upgrade does not mark template1 as a system
database
PG Bug reporting form <noreply@postgresql.org> writes:
> 4. Open pgAdmin 4, connect to the PostgreSQL 13.0 server and expand
> the Databases node.
> Expected result:
> The node has [postgres].
> Actual result:
> The node has [postgres] and [template1].
There's no particular concept of a "system database" in Postgres, so I don't
know what pgadmin is doing to decide which databases to show or not show,
but evidently it's not too well thought out.
(The closest concept I can think of is whether a DB is marked datistemplate,
but a test confirms that pg_upgrade successfully preserves that property on
template0 and template1.)
I'd suggest you file this complaint on the pgadmin lists.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: BUG #16645: pg_upgrade does not mark template1 as a system database
2020-09-30 01:50 BUG #16645: pg_upgrade does not mark template1 as a system database PG Bug reporting form <noreply@postgresql.org>
2020-09-30 02:45 ` Re: BUG #16645: pg_upgrade does not mark template1 as a system database Tom Lane <tgl@sss.pgh.pa.us>
2020-09-30 04:11 ` RE: BUG #16645: pg_upgrade does not mark template1 as a system database Y. NAKAGAWA <nakagawa@goodf.co.jp>
2020-10-06 09:44 ` RE: BUG #16645: pg_upgrade does not mark template1 as a system database Y. NAKAGAWA <nakagawa@goodf.co.jp>
@ 2020-10-06 13:55 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2020-10-06 13:55 UTC (permalink / raw)
To: Y. NAKAGAWA <nakagawa@goodf.co.jp>; +Cc: pgsql-bugs@lists.postgresql.org
"Y. NAKAGAWA" <nakagawa@goodf.co.jp> writes:
> However, after some grep-ing on pgAdmin4 source tree, I found that [System
> Database?] shows pg_database.oid <= pg_database.datlastsysoid.
That is a very meaningless condition, they shouldn't do that.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2020-10-06 13:55 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 01:50 BUG #16645: pg_upgrade does not mark template1 as a system database PG Bug reporting form <noreply@postgresql.org>
2020-09-30 02:45 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-09-30 04:11 ` Y. NAKAGAWA <nakagawa@goodf.co.jp>
2020-10-06 09:44 ` Y. NAKAGAWA <nakagawa@goodf.co.jp>
2020-10-06 13:55 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox