From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Warning in the RecordTransactionAbort routine during compilation with O3 flag
Date: Tue, 10 Dec 2019 12:18:49 +0500
Message-ID: <04868ee5-4d76-2798-0010-0f4b478e7762@postgrespro.ru> (raw)
In-Reply-To: <20191210031328.GG72921@paquier.xyz>
References: <a7e28b83-27b1-4e1c-c76b-4268c4b785bc@postgrespro.ru>
<20191209080316.GA72921@paquier.xyz>
<287cdd37-4021-da81-0378-cd367a279577@postgrespro.ru>
<20191210031328.GG72921@paquier.xyz>
10.12.2019 08:13, Michael Paquier wrote:
> On Mon, Dec 09, 2019 at 02:03:43PM +0500, Andrey Lepikhov wrote:
>> We already have assertion on the twophase_gid variable. But compiler is not
>> so smart and can't find a link between the XACT_XINFO_HAS_GID flag and
>> state of twophase_gid pointer.
>
> Well, gcc-9 got visibly smarter on that point :)
>
>> Ok. In accordance with your review, I have prepared a new version of the
>> patch.
>
> Regarding formatting.c, I can see the point of avoiding future
> mistakes, and I would go a bit further as per the attached for
> consistency between all variables. have_error is a bit trickier
> though as it gets moved around more layers so doing an initialization
> in the middle is not really an option. Anyway, we can do that rather
> cleanly from the entry point of do_to_timestamp() to bring more
> consistency for variables which are always expected and the optional
> ones. What do you think?
I have small experience in formatting.c code. But this patch and idea
looks good.
>
> For the second one in xact.c, I am not really on board of doing
> something based on the proposals because this reduces the code
> visibility, and gcc is clearly wrong in its assumptions because the
> state cannot be reached.
Ok. I switched to gcc-9 and now have no problem.
--
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: a.lepikhov@postgrespro.ru, michael@paquier.xyz
Subject: Re: Warning in the RecordTransactionAbort routine during compilation with O3 flag
In-Reply-To: <04868ee5-4d76-2798-0010-0f4b478e7762@postgrespro.ru>
References: <a7e28b83-27b1-4e1c-c76b-4268c4b785bc@postgrespro.ru> <20191209080316.GA72921@paquier.xyz> <287cdd37-4021-da81-0378-cd367a279577@postgrespro.ru> <20191210031328.GG72921@paquier.xyz> <04868ee5-4d76-2798-0010-0f4b478e7762@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox