From: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: David G. Johnston <david.g.johnston@gmail.com>
To: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: David Rowley <dgrowley@gmail.com>
Subject: Re: BUG #15383: Join Filter cost estimation problem in 10.5
Date: Tue, 1 Dec 2020 18:23:55 +0300
Message-ID: <06456467-39c7-6605-b016-3c765d395a4f@postgrespro.ru> (raw)
In-Reply-To: <CAKFQuwbzWqoHy3Bq+6-mH+pYunCjYObUMcKbE8Qmwk_qtYZHTw@mail.gmail.com>
References: <153683552113.22350.18441286362867559841@wrigleys.postgresql.org>
<CAApHDvrGnJpE=eHPvSPGd1mmxGKUenyCFHbzG9c0cyqAeq_3SA@mail.gmail.com>
<160407451328.1204.14768882331709534502.pgcf@coridan.postgresql.org>
<CAKFQuwbzWqoHy3Bq+6-mH+pYunCjYObUMcKbE8Qmwk_qtYZHTw@mail.gmail.com>
On 30.10.2020 19:33, David G. Johnston wrote:
> On Fri, Oct 30, 2020 at 9:16 AM Anastasia Lubennikova
> <lubennikovaav@gmail.com <mailto:lubennikovaav@gmail.com>> wrote:
>
> Status update for a commitfest entry.
>
> It looks like there was no real progress on this issue since
> April. I see only an experimental patch. What kind of review does
> it need right now? Do we need more testing or maybe production
> statistics for such queries?
>
> David, are you going to continue working on it?
> Can you, please, provide a short summary of the problem and list
> open questions for reviewers.
>
> The new status of this patch is: Waiting on Author
>
>
> I agree that updating a wiki seems like an unappealing conclusion to
> this entry. I'm on the fence whether we just leave it in the cf and
> get a periodic nag when it gets bumped. As we are describing real
> problems or potential improvements to live portions of the codebase
> ISTM that adding code comments near to those locations would be
> warranted. The commit message can reference this thread. There seems
> to already be a convention for annotating code comments in such a way
> that they can be searched for - which basically is what sticking it in
> the wiki would accomplish but the searcher would have to look in the
> codebase and not on a website. For the target audience of this
> specific patch that seems quite reasonable.
>
> David J.
>
Here we are again.
The commitfest is closed now and the discussion haven't moved from where
it was a month ago.
I don't see any use in moving it to the next CF as is and I don't want
to return it either, as this is clearly a bug.
I think we have a few options:
1. We can add it into TODO until better times.
2. We can write a patch to address this problem in code comments.
3. We can maybe CC this thread to someone and ask for help. Do you know
people, who have expertise in this area?
None of these options is perfect, but the second option will perhaps be
a good compromise.
David, can you, please submit a patch?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: a.lubennikova@postgrespro.ru, david.g.johnston@gmail.com, lubennikovaav@gmail.com, pgsql-hackers@lists.postgresql.org, dgrowley@gmail.com
Subject: Re: BUG #15383: Join Filter cost estimation problem in 10.5
In-Reply-To: <06456467-39c7-6605-b016-3c765d395a4f@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox