pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: skoposov@ed.ac.uk, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
Date: Wed, 18 Nov 2020 19:02:34 -0500
Message-ID: <1010421.1605744154@sss.pgh.pa.us> (raw)
In-Reply-To: <20201118230529.6u7fyl6trnepekgc@alap3.anarazel.de>
References: <16722-93043fb459a41073@postgresql.org>
	<95bfb4b5-2e0e-8ab7-12cf-03fae3367c52@oss.nttdata.com>
	<CABUevExw6AHqC_U7nH83=rvF-xY_U8AUDbR94kBDqDR0hGqKXw@mail.gmail.com>
	<20201118192743.kr43onoxci5gexjx@alap3.anarazel.de>
	<CABUevEw69Es-s7fcvrNfZx9SWoPt-ZX+GJNFn_wNPoMtYAvNCw@mail.gmail.com>
	<20201118230529.6u7fyl6trnepekgc@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2020-11-18 23:12:10 +0100, Magnus Hagander wrote:
>> That said, I'd really prefer to see *some* kind of counter that could
>> get people noticing this a bit earlier, rather than just bugging them
>> in the logfile once it's gone over a threshold.  A statistics counter
>> maybe, but I guess that'd have to be tracked at a per-table level to
>> be really useful, which would make it potentially fairly expensive to
>> keep around...

> I'd rather spend effort to solve the underlying issue. It's a bit more
> work, but not crazily so, I think. Even the pg_upgrade pieces aren't
> that hard to solve.

Yeah.  If we're going to put work into this, widening the IDs used
to identify toast values seems like the right work to be doing.

Having said that, I had imagined that we might never have to fix it,
because if your table is big enough that it has a problem of this
ilk then likely you want to partition it anyway.  And partitioning
solves the problem since each partition has its own toast table.

			regards, tom lane





view thread (28+ messages)  latest in thread

Message-ID: <1010421.1605744154@sss.pgh.pa.us>
Permalink:  ../1010421.1605744154@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1010421.1605744154@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, magnus@hagander.net, masao.fujii@oss.nttdata.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
  In-Reply-To: <1010421.1605744154@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox