From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: digoal@126.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16302: too many range table entries - when count partition table(65538 childs)
Date: Tue, 17 Mar 2020 10:42:08 -0400
Message-ID: <1032.1584456128@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoanuqV8bFRjGeWoNFNZfQJOwYq04DQ6gsLh5VzC-D2thw@mail.gmail.com>
References: <16302-e45634e2c0e34e97@postgresql.org>
<32763.1584198185@sss.pgh.pa.us>
<CA+HiwqFZRY=t9jzgbMq5aiKSLWsAj_XhycpULY_PY2W65_cLNw@mail.gmail.com>
<28094.1584326310@sss.pgh.pa.us>
<CA+TgmoZoqQvYD5TmyzQGHw2HxmugLJ18j0wNPOJ9yUqYc=iy7g@mail.gmail.com>
<31331.1584452939@sss.pgh.pa.us>
<CA+TgmoanuqV8bFRjGeWoNFNZfQJOwYq04DQ6gsLh5VzC-D2thw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Mar 17, 2020 at 9:49 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We'd have to widen AttrNumber to int32 and find all the places that
>> assume it's only 16 bits. (Good luck with testing your way to having
>> any confidence in having found them all, so I'm not sure exactly how
>> to acquire such confidence.) Maybe someday that will be a profitable
>> use of developer effort, but I have to say that I think that day is
>> a long way off.
> That sounds like a lot of work, but I think AttrNumber is used to
> store varattno, and I think varno is typically stored using either
> Index or int, both of which are 32 bits. Am I confused?
Argh, -ENOCAFFEINE. You're right, AttrNumber is not the relevant
type here. There's still an issue of whether anyplace has tried
to store a varno in less-than-int, but it seems less likely than
I was thinking earlier.
> (It doesn't seem like we're all that careful about whether we're using
> int, which is signed, or Index, which is unsigned, and we might want
> to go around and tighten that up.
Yeah, I'd be leery of trying to use that last bit. The cost-benefit
ratio on that is *definitely* not attractive.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, amitlangote09@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16302: too many range table entries - when count partition table(65538 childs)
In-Reply-To: <1032.1584456128@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox