From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: andrewbille@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16622: pg_dump produces erroneus ALTER TABLE statement for a table with an inherited generated column
Date: Mon, 21 Sep 2020 17:20:22 -0400
Message-ID: <1040807.1600723222@sss.pgh.pa.us> (raw)
In-Reply-To: <3B0AA616-F9E9-40F4-9350-2F82E6E88BC9@yesql.se>
References: <16622-779a79851b4e2491@postgresql.org>
<3B0AA616-F9E9-40F4-9350-2F82E6E88BC9@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 18 Sep 2020, at 06:58, PG Bug reporting form <noreply@postgresql.org> wrote:
>> psql:dump.sql:50: ERROR: column "b" of relation "gtest1_1" is a generated
>> column
> I can reproduce this in git HEAD too.
Yeah, this has been complained of before, notably at [1].
The latest patch in that thread is Masahiko-san's at [2],
which is similar to but not exactly like yours.
Could you review/test that one?
(I suspect you are right that binary-upgrade is a special case,
but wouldn't the existing pg_upgrade test catch that? Also,
do we need more test cases?)
regards, tom lane
[1] https://www.postgresql.org/message-id/flat/15830.1575468847%40sss.pgh.pa.us
[2] https://www.postgresql.org/message-id/CA%2Bfd4k6pLzrZDQsdsxcS06AwGRf1DgwOw84sFq9oXNw%2B83nB1g%40mail...
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16622: pg_dump produces erroneus ALTER TABLE statement for a table with an inherited generated column
In-Reply-To: <1040807.1600723222@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox