pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: egashira.yusuke@fujitsu.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17254: Crash with 0xC0000409 in pg_stat_statements when pg_stat_tmp\pgss_query_texts.stat exceeded 2GB.
Date: Sun, 31 Oct 2021 18:46:34 -0400
Message-ID: <1052015.1635720394@sss.pgh.pa.us> (raw)
In-Reply-To: <CAC+AXB3L3pB-SGqrLBiXqg9yQZDNURGgyT63QRAnZ=o_oUb9-A@mail.gmail.com>
References: <17254-a926c89dc03375c2@postgresql.org>
	<CAC+AXB21yF41p4fWgUOkG1PBA-Ezw-8U0Q=Bint9OQ56qyMPYw@mail.gmail.com>
	<CAC+AXB0fozNPMgRTP+PgFMrGcSn2zER0zgcrEbRV0NvpZqmE=A@mail.gmail.com>
	<CAC+AXB2tWxoZgj6BnoQaxiWw=vKBxUPtyBn7d8jhHRqxv7xRRw@mail.gmail.com>
	<840436.1635611203@sss.pgh.pa.us>
	<CAC+AXB2vCUOj6x8drBVUVCgjyy4ZFUu-TFBuNVW=7Emh44EC=w@mail.gmail.com>
	<856857.1635627048@sss.pgh.pa.us>
	<975808.1635700062@sss.pgh.pa.us>
	<CAC+AXB3L3pB-SGqrLBiXqg9yQZDNURGgyT63QRAnZ=o_oUb9-A@mail.gmail.com>

=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes:
> On Sun, Oct 31, 2021 at 6:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Here's a quick patch for that.  I don't have any ability to check it
>> on Windows, but the logic is easy to verify by reducing the arbitrary
>> constant to something small.  (I used 1GB, not INT_MAX, because I figured
>> we ought to read in multiples of a filesystem block if possible.)

> I have tested the patch in Windows and it works as expected.

Great, thanks for testing!

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <1052015.1635720394@sss.pgh.pa.us>
Permalink:  ../1052015.1635720394@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1052015.1635720394@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, juanjo.santamaria@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17254: Crash with 0xC0000409 in pg_stat_statements when pg_stat_tmp\pgss_query_texts.stat exceeded 2GB.
  In-Reply-To: <1052015.1635720394@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox