pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17062: Assert failed in RemoveRoleFromObjectPolicy() on DROP OWNED policy applied to duplicate role
Date: Thu, 17 Jun 2021 17:51:18 -0400
Message-ID: <1068096.1623966678@sss.pgh.pa.us> (raw)
In-Reply-To: <1067500.1623965562@sss.pgh.pa.us>
References: <17062-11f471ae3199ca23@postgresql.org>
	<1066940.1623964553@sss.pgh.pa.us>
	<1067500.1623965562@sss.pgh.pa.us>

I wrote:
> So the proximate problem is RemoveRoleFromObjectPolicy's unfounded
> assumption that there are no duplicate OIDs in a pg_policy.polroles
> entry.  But that function has got some other serious problems too:

While I'm whining ... that function's permissions checks seem
completely out of line too.  How is it that, if I have the right
to drop some role, I lose that right if the role is mentioned in
a policy of some relation I don't own?  It feels like this function
was written by copy-and-pasting a whole bunch of irrelevant logic.

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <1068096.1623966678@sss.pgh.pa.us>
Permalink:  ../1068096.1623966678@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1068096.1623966678@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17062: Assert failed in RemoveRoleFromObjectPolicy() on DROP OWNED policy applied to duplicate role
  In-Reply-To: <1068096.1623966678@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox