pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: ewaldo@healthetechs.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue
Date: Sun, 05 Apr 2020 11:26:36 -0400
Message-ID: <10837.1586100396@sss.pgh.pa.us> (raw)
In-Reply-To: <db920c8a-063e-a320-c5e8-096f0eedc154@2ndquadrant.com>
References: <16342-50008a509308f4ca@postgresql.org>
	<db920c8a-063e-a320-c5e8-096f0eedc154@2ndquadrant.com>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Confirmed.  Attached is a patch to fix it.  Thanks for the report!

LGTM.  Perhaps extend the comment block just above, adding something
like "We must fill the attmap now so it can be used to process
GENERATED default expressions in the per-column loop."

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <10837.1586100396@sss.pgh.pa.us>
Permalink:  ../10837.1586100396@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/10837.1586100396@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, ewaldo@healthetechs.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16342: CREATE TABLE LIKE INCLUDING GENERATED column order issue
  In-Reply-To: <10837.1586100396@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox