public inbox for [email protected]  

help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Virender Singla <[email protected]>
Cc: [email protected]
Cc: Aniket Jha <[email protected]>
Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
Date: Fri, 27 Feb 2026 16:22:25 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CA+TgmoauoiW4ydDhdrseg+DD4Kwha=+TSZp18BrJeHKx3o1Fdw@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYFc1x11Y7AHxn6Jb0mvJ9-aPttmjqezj=YKnHmqVb-Wg@mail.gmail.com>
	<[email protected]>
	<CA+TgmobNKFc34nj+w6iX0zWJ1=mfYWqQS91PqsJrm4VD4o1yOw@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYJ8Y1G1r9U7pRwnyw=8dmM0xygLguE+bdihkN8GwPuCQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmobZRL02-R7k_i3ENYz8CmqCPUZv6cHY51BejqPy7OhFJw@mail.gmail.com>
	<[email protected]>

I wrote:
> I'd be content to use those wordings (except I think our style
> guide wants detail to be punctuated like a sentence).  I'll wait
> a day or so to see if anyone has a better idea, though.

When I looked at the code more closely, I realized that it already
doesn't dump grantors when dumping from pre-v16.  I'm inclined to
think that is an overreaction to the possible unreliability of the
data (and from your comment upthread you might agree).  But given
the lack of complaints about it, let's leave that as-is for now.
The immediate problem is that the code is allowing a null grantor to
suppress the GRANT altogether, *even if it's not going to use the
grantor*.  Clearly that's silly.  But if we're not going to use
the grantor, let's skip trying to fetch it, which means we also
don't need the info-level variant of the message.

So I end with the attached draft patch.

			regards, tom lane

#text/x-diff; name="v1-clean-up-dumpRoleMembership.patch" [v1-clean-up-dumpRoleMembership.patch] /home/tgl/pgsql/v1-clean-up-dumpRoleMembership.patch






reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Major Version Upgrade failure due to orphan roles entries in catalog
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox