From: Tom Lane <tgl@sss.pgh.pa.us>
To: kensuke.okamura@kantei.co.jp
Cc: pgsql-bugs@lists.postgresql.org, Bruce Momjian <bruce@momjian.us>
Subject: Re: BUG #16688: psql removes only LF without CR at end of backquotes on windows.
Date: Tue, 27 Oct 2020 23:27:05 -0400
Message-ID: <1224124.1603855625@sss.pgh.pa.us> (raw)
In-Reply-To: <16688-c649c7b69cd7e6f8@postgresql.org>
References: <16688-c649c7b69cd7e6f8@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> psql removes only LF without CR at end of backquotes on windows.
Hmm, seems like b654714f9 missed this. psqlscanslash.l has
fd = popen(cmd, PG_BINARY_R);
...
/* strip any trailing newline */
if (cmd_output.len > 0 &&
cmd_output.data[cmd_output.len - 1] == '\n')
cmd_output.len--;
But rather than mess with that newline-chomping code, I'm
inclined to wonder why we're using PG_BINARY_R for input
that we clearly expect to be textual. Most of our other
popen's do not do that.
Bruce, this seems to date to 98e9775a3 ... don't suppose
you remember that? I see the point about control-Z in text
files, but I wonder how plausible that is for popen cases.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, kensuke.okamura@kantei.co.jp, bruce@momjian.us
Subject: Re: BUG #16688: psql removes only LF without CR at end of backquotes on windows.
In-Reply-To: <1224124.1603855625@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox