From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace
Date: Wed, 28 Oct 2020 09:59:24 -0400
Message-ID: <1251838.1603893564@sss.pgh.pa.us> (raw)
In-Reply-To: <20201028134045.GA6709@alvherre.pgsql>
References: <20201028134045.GA6709@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2020-Oct-28, Michael Paquier wrote:
>> Haven't thought of that approach, good idea! That would not be
>> backpatchable but that would be a solution that does not require
>> creating files where we don't need them. Did you begin to look at
>> that?
> I haven't started on this one yet, but I intend to do so shortly.
> Strictly speaking, we can still introduce a new category of pg_shdepend
> entries in back branches; it won't break anything that works today.
Yeah, as long as the patched version won't actively fail when those
pg_shdepend entries are missing, I don't think a backpatch is too
hazardous. It might be worth checking that the extra entries don't
create huge problems if one does downgrade after some of them exist
--- but my feeling for how that mechanism works is that it'd Just
Work, and indeed provide the missing DROP protection even without
explicit action by the backend.
I would not be too excited about offering instructions for people
to manually add/remove the dependency entries. The amount of
value added, versus the risks of bollixing things completely,
doesn't sound like a good tradeoff.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, michael@paquier.xyz, tomas.vondra@2ndquadrant.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16577: Segfault on altering a table located in a dropped tablespace
In-Reply-To: <1251838.1603893564@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox