From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Timo Stolz <timo.stolz@nullachtvierzehn.de>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Jonas Reinsch <jonas.reinsch@pitchview.de>
Cc: Laura Schlimmer <laura.schlimmer@pitchview.de>
Subject: Re: If a row-level security policy contains a set returning function, pg_dump returns an incorrect serialization of that policy if the return type of the function was altered
Date: Thu, 21 Jul 2022 13:58:44 -0400
Message-ID: <130689.1658426324@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEZATCUy6Uqtv=_PYbc-CmpkfF2vBxE0ZhyXRr_u1nt=wjHCkw@mail.gmail.com>
References: <5c91267e-3b6d-5795-189c-d15a55d61dbb@nullachtvierzehn.de>
<1983818.1658350464@sss.pgh.pa.us>
<CAEZATCUy6Uqtv=_PYbc-CmpkfF2vBxE0ZhyXRr_u1nt=wjHCkw@mail.gmail.com>
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Wed, 20 Jul 2022 at 21:54, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The larger issue that this touches on is that we don't prevent you from
>> dropping the composite type's column even when the query using the
>> dependent function has hard references to that column (e.g, it's actually
>> output by the view). Maybe sometime somebody ought to work on tightening
>> that up. In the meantime though, it's bad for EXPLAIN or pg_dump to fail
>> altogether on such cases, so I propose the behavior shown in the attached
>> patch.
> +1. LGTM.
Pushed, thanks for reviewing!
I think I'll go take a look at the missing-dependency aspect now.
I realized from checking the commit log that we've been putting
off doing that since 2014, if not before. Really should fix it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, timo.stolz@nullachtvierzehn.de, pgsql-bugs@lists.postgresql.org, jonas.reinsch@pitchview.de, laura.schlimmer@pitchview.de
Subject: Re: If a row-level security policy contains a set returning function, pg_dump returns an incorrect serialization of that policy if the return type of the function was altered
In-Reply-To: <130689.1658426324@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox