pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: ertugrul9090@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15511: Drop table error "invalid argument"
Date: Tue, 5 Feb 2019 12:28:44 +0100
Message-ID: <131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com> (raw)
In-Reply-To: <3314.1544139501@sss.pgh.pa.us>
References: <20181206210042.6fu2tkbxy3vehwul@alvherre.pgsql>
	<30307.1544130494@sss.pgh.pa.us>
	<3314.1544139501@sss.pgh.pa.us>

On 07/12/2018 00:38, Tom Lane wrote:
> ... so my preliminary result is that there's a *boatload* of "invalid"
> format strings in our translation files, all of them apparently with
> the extra-space disease.  See attached.

A bit of follow-up:  I have committed fixes for all the erroneous uses
of space "flags" in translated format strings.  These will then be in
the next minor releases.

I also looked into the gettext/msgfmt source code.  We know that it does
check for format string compatibility, but I found that it only checks
the general type, not the formatting flags.  I suppose this is not
unreasonable, since a translation might want to space or align something
differently.  So we still don't have an easy way to check for this in
the future.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (14+ messages)

Message-ID: <131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com>
Permalink:  ../131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com/
Also on:    postgresql.org/message-id/131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, ertugrul9090@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15511: Drop table error "invalid argument"
  In-Reply-To: <131ffaa0-0dbd-6da2-cdad-7757e234d0cb@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox