pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Ash M <makmarath@hotmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name
Date: Sun, 10 Feb 2019 17:39:19 -0500
Message-ID: <13325.1549838359@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKJS1f-6kdi2KyyCuHf4fM-Cuz4w99D1mMsOxhQEw2oaA5tW8g@mail.gmail.com>
References: <CAKJS1f9nQyOcCdjJ0HP=DCRanDLOCp7+L2QCnR2BAXM-8Zh5vw@mail.gmail.com>
	<201901071454.wxkoyoq4s5qp@alvherre.pgsql>
	<CAKJS1f9t5_Zfc7KVYmpsMjW3BqR_rXv2B3C7i7qukwdh11+yjA@mail.gmail.com>
	<19400.1546994166@sss.pgh.pa.us>
	<CAKJS1f-2-wVsN5zXaKWdp4xOUkkstnoPo0Lis6RQ=AEo3_pcig@mail.gmail.com>
	<CAKJS1f-ad5i_rtnRQiU4sE5L8M3rZT-JEz7eT9KSqPH0Z-0cPQ@mail.gmail.com>
	<CAKJS1f-6kdi2KyyCuHf4fM-Cuz4w99D1mMsOxhQEw2oaA5tW8g@mail.gmail.com>

David Rowley <david.rowley@2ndquadrant.com> writes:
> Updated patch attached again.  This time due to a newly added call to
> LookupFuncName()  in 1fb57af92.

Hmm ... I'd not looked at this before, but now that I do, the new API
for LookupFuncName seems mighty confused, or at least confusingly
documented.  It's not clear what the combinations of the flags actually
do, or why you'd want to use them.

I wonder whether you'd be better off replacing the two bools with an
enum, or something like that.

			regards, tom lane




view thread (38+ messages)  latest in thread

Message-ID: <13325.1549838359@sss.pgh.pa.us>
Permalink:  ../13325.1549838359@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13325.1549838359@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, alvherre@2ndquadrant.com, makmarath@hotmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name
  In-Reply-To: <13325.1549838359@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox