pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: andrewbille@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.
Date: Wed, 15 Oct 2025 20:45:47 -0400
Message-ID: <1342348.1760575547@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvp-BsfUne0TckE5f8-E9Ou3+2+fT0aN2OB+ccC88zy-yQ@mail.gmail.com>
References: <19086-871ff11017d03dc5@postgresql.org>
	<aO6mUj9H2WpEFylG@nathan>
	<1000041.1760471415@sss.pgh.pa.us>
	<aO7IoIEnQDbtFzrs@nathan>
	<CAApHDvoU2O-_zKNL-toHwkDcMXCzzvgRUTnA3baEEhCB4vqMRw@mail.gmail.com>
	<aO_KwnHm2AVn0E4m@nathan>
	<CAApHDvrcM4G0==52jFoAvmxk6ZRjXKq7nkik=fqq6BH=dSJsYA@mail.gmail.com>
	<1324003.1760565328@sss.pgh.pa.us>
	<CAApHDvrffhKALh3jQM6Kmar5nt=2xgHC_0ErhTFvM32b_JT-Cw@mail.gmail.com>
	<1334977.1760571380@sss.pgh.pa.us>
	<CAApHDvp-BsfUne0TckE5f8-E9Ou3+2+fT0aN2OB+ccC88zy-yQ@mail.gmail.com>

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 16 Oct 2025 at 12:36, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (Hmm ... but on the third hand, if we only need one of the
>> two strings, couldn't we mechanize that by wrapping the
>> pg_get_indexdef call in CASE WHEN c.contype IS DISTINCT FROM 'x'
>> ?)

> Unless I'm mistaken, it looks like the "indexdef" field is used only
> when there's no corresponding constraint with contype 'p,', 'u' or
> 'x'.

Ah.  I hadn't researched that, but it makes sense.

> Wouldn't it be more like:

> CASE WHEN c.conrelid IS NULL THEN
> pg_catalog.pg_get_indexdef(i.indexrelid) ELSE '' END AS indexdef

I'd leave out the ELSE so that you get a null if the function
isn't run, but yeah.  (The places saving these query results would
need PQgetisnull tests, too.)

			regards, tom lane





view thread (20+ messages)  latest in thread

Message-ID: <1342348.1760575547@sss.pgh.pa.us>
Permalink:  ../1342348.1760575547@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1342348.1760575547@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, nathandbossart@gmail.com, andrewbille@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.
  In-Reply-To: <1342348.1760575547@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox