From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Bruno Bonfils <asyd@asyd.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: sshang@pivotal.io, Alexey Bashtanov <alexey@brandwatch.com>
Subject: Re: About #13489, array dimensions and CREATE TABLE ... LIKE
Date: Mon, 20 Nov 2023 21:04:21 -0500
Message-ID: <1402391.1700532261@sss.pgh.pa.us> (raw)
In-Reply-To: <ZVwI_ozT8z9MCnIZ@momjian.us>
References: <ZD+14YZ4IUue8Rhi@gendo.asyd.net>
<ZPuN20z3HcBXdKow@momjian.us>
<ZVwI_ozT8z9MCnIZ@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> I would like to apply this patch to master because I think our current
> deficiencies in this area are unacceptable.
I do not think this is a particularly good idea, because it creates
the impression in a couple of places that we track this data, when
we do not really do so to any meaningful extent.
> An alternate approach would
> be to remove pg_attribute.attndims so we don't even try to preserve
> dimensionality.
I could get behind that, perhaps. It looks like we're not using the
field in any meaningful way, and we could simplify TupleDescInitEntry
and perhaps some other APIs.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, asyd@asyd.net, pgsql-hackers@postgresql.org, alexey@brandwatch.com
Subject: Re: About #13489, array dimensions and CREATE TABLE ... LIKE
In-Reply-To: <1402391.1700532261@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox