From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16703: pg-dump fails to process recursive view definition
Date: Thu, 05 Nov 2020 10:41:48 -0500
Message-ID: <1473888.1604590908@sss.pgh.pa.us> (raw)
In-Reply-To: <1438431.1604588428@sss.pgh.pa.us>
References: <16703-e348f58aab3cf6cc@postgresql.org>
<1438431.1604588428@sss.pgh.pa.us>
I wrote:
> It seems like the least painful solution might be to teach
> LockTableRecurse to detect recursion and just not recurse into
> a view it's already locked. (BTW, I wonder if we shouldn't
> have a stack depth check there, too.)
Oh, I see it already has a recursion test ... it's just that throwing
an error is an unnecessarily harsh reaction. We can just stop
recursing. Will push a fix shortly.
(Also, we need no check_stack_depth call here, because
expression_tree_walker has one.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16703: pg-dump fails to process recursive view definition
In-Reply-To: <1473888.1604590908@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox