pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Edwin Polkerman <edwin.polkerman@splendiddata.com>
Subject: Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647]
Date: Thu, 03 Sep 2026 13:29:43 -0400
Message-ID: <1477911.1788456583@sss.pgh.pa.us> (raw)
In-Reply-To: <D36A4968-A56F-44C7-B4A4-1AC4CC936903@yesql.se>
References: <19647-d18354ebe2134a6d@postgresql.org>
	<CAOYmi+=QyQHvH2Ehqb+Je3nvv-+Qg6Xp8fG+cNs-KwAoHvNyBA@mail.gmail.com>
	<b39d0277-de91-4fa1-b912-e3c8ee38ccf1@splendiddata.com>
	<CAOYmi+myfnx3eC-jpTxGgtTPL5eMitu_nV9PkyqDS8W4puoNcw@mail.gmail.com>
	<cd4f60fe-c8e7-4c15-ae98-6056242d0081@splendiddata.com>
	<CAOYmi+=prw7DdrMf2-k8E2jhbi6dQ2v03xJJYnC0ZwBe4GLwPg@mail.gmail.com>
	<CAOYmi+=E0zz+_MgQXAoOyn5C0vW53740izzRiTv6excqtCJfRg@mail.gmail.com>
	<D36A4968-A56F-44C7-B4A4-1AC4CC936903@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> On 3 Sep 2026, at 19:10, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>> The inciting event is that an extension drops a file called
>> pgactive.stat into global/. We could say "don't do that", in which
>> case I think we should follow Robert's idea in [1] and complain about
>> the existence of the file itself rather than the lack of checksummable
>> material. Or we could say "that's fine" and adjust pg_checksums to
>> continue onwards if the filename isn't what we expect.

> I'm not sure I have a strong preference, keeping it in sync with pg_basebackup
> seems like a pretty good strategy to make it easier for users.

It looks to me like there was a fair amount of consensus behind
025584a16, so I think we should conclude that pg_basebackup's new
behavior (ignore stray files) is the right thing and it was an
oversight that pg_checksums wasn't adjusted similarly.

			regards, tom lane





view thread (7+ messages)  latest in thread

Message-ID: <1477911.1788456583@sss.pgh.pa.us>
Permalink:  ../1477911.1788456583@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1477911.1788456583@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, jacob.champion@enterprisedb.com, pgsql-hackers@lists.postgresql.org, edwin.polkerman@splendiddata.com
  Subject: Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647]
  In-Reply-To: <1477911.1788456583@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox