pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Mahendra Singh <mahi6run@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
Date: Tue, 07 Jan 2020 13:06:08 -0500
Message-ID: <14868.1578420368@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoYCd6gaCy2-YzO5DyR=YFxRAbKaC5ucL9DL4jSnTgs14A@mail.gmail.com>
References: <20191225032410.GG3448@paquier.xyz>
	<20191226135329.GA249363@paquier.xyz>
	<CAKYtNAqq_XP32DTbaWuuOHZpE6HSKs3xOj_ONMWNoFzoJ7iCYQ@mail.gmail.com>
	<28862.1577382716@sss.pgh.pa.us>
	<CAKYtNApQ4ctL5AnP+2rSoV9vB+cmXp5OiwponY5QL_w4C5SH_w@mail.gmail.com>
	<20191227090604.GA540891@paquier.xyz>
	<CA+TgmobL4npEX5=E5h=5Jm_9mZun3MT39Kq2suJFVeamc9skSQ@mail.gmail.com>
	<20200106014202.GA3598@paquier.xyz>
	<CA+TgmobPJ+CQGr1nKnt4rNikgBqHvXtJ+x8UW0U_kR6ksf2D-A@mail.gmail.com>
	<31319.1578332027@sss.pgh.pa.us>
	<20200107002216.GA2386@paquier.xyz>
	<CA+TgmoYCd6gaCy2-YzO5DyR=YFxRAbKaC5ucL9DL4jSnTgs14A@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jan 6, 2020 at 7:22 PM Michael Paquier <michael@paquier.xyz> wrote:
>> For the second one, I would really wish that we keep the restriction
>> put in place by a052f6c until we actually figure out how to make the
>> operation safe in the ways we want it to work because this puts
>> the catalogs into an inconsistent state for any object type able to
>> use a temporary schema, like functions, domains etc. for example able
>> to use "pg_temp" as a synonym for the temp namespace name.  And any
>> connected user is able to do that.

> So what?

I still agree with Robert that a052f6c is a bad idea.  It's not the case
that that's blocking "any connected user" from causing an issue.  The
temp schemas are always owned by the bootstrap superuser, so only a
superuser could delete them.  All that that patch is doing is preventing
superusers from doing something that they could reasonably wish to do,
and that is perfectly safe when there's not concurrent usage of the
schema.  We are not normally that nanny-ish, and the case for being so
here seems pretty thin.

			regards, tom lane





view thread (37+ messages)  latest in thread

Message-ID: <14868.1578420368@sss.pgh.pa.us>
Permalink:  ../14868.1578420368@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/14868.1578420368@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, michael@paquier.xyz, mahi6run@gmail.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
  In-Reply-To: <14868.1578420368@sss.pgh.pa.us>
  References: <20191225032410.GG3448@paquier.xyz> <20191226135329.GA249363@paquier.xyz> <CAKYtNAqq_XP32DTbaWuuOHZpE6HSKs3xOj_ONMWNoFzoJ7iCYQ@mail.gmail.com> <28862.1577382716@sss.pgh.pa.us> <CAKYtNApQ4ctL5AnP+2rSoV9vB+cmXp5OiwponY5QL_w4C5SH_w@mail.gmail.com> <20191227090604.GA540891@paquier.xyz> <CA+TgmobL4npEX5=E5h=5Jm_9mZun3MT39Kq2suJFVeamc9skSQ@mail.gmail.com> <20200106014202.GA3598@paquier.xyz> <CA+TgmobPJ+CQGr1nKnt4rNikgBqHvXtJ+x8UW0U_kR6ksf2D-A@mail.gmail.com> <31319.1578332027@sss.pgh.pa.us> <20200107002216.GA2386@paquier.xyz> <CA+TgmoYCd6gaCy2-YzO5DyR=YFxRAbKaC5ucL9DL4jSnTgs14A@mail.gmail.com> <14868.1578420368@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox