From: Tom Lane <tgl@sss.pgh.pa.us>
To: balazs@obiserver.hu
Cc: pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: [BUGS] BUG #14825: enum type: unsafe use?
Date: Fri, 22 Sep 2017 17:46:08 -0400
Message-ID: <15165.1506116768@sss.pgh.pa.us> (raw)
In-Reply-To: <20170922185904.1448.16585@wrigleys.postgresql.org>
References: <20170922185904.1448.16585@wrigleys.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
balazs@obiserver.hu writes:
> PostgreSQL version: 10beta4
> testdb=# begin;
> BEGIN
> testdb=# create type enumtype as enum ('v1', 'v2');
> CREATE TYPE
> testdb=# alter type enumtype owner to testrole;
> ALTER TYPE
> testdb=# create table testtable (enumcolumn enumtype not null default 'v1');
> ERROR: unsafe use of new value "v1" of enum type enumtype
> HINT: New enum values must be committed before they can be used.
Hmm, that's pretty annoying. It's happening because check_safe_enum_use
insists that the enum's pg_type entry not be updated-in-transaction.
We thought that the new rules instituted by 15bc038f9 would be generally
more convenient to use than the old ones --- but this example shows
that, for example, pg_dump scripts involving enums often could not
be restored inside a single transaction.
I'm not sure if that qualifies as a stop-ship problem, but it ain't
good, for sure. We need to look at whether we should revert 15bc038f9
or somehow revise its rules.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, balazs@obiserver.hu, andrew@dunslane.net
Subject: Re: [BUGS] BUG #14825: enum type: unsafe use?
In-Reply-To: <15165.1506116768@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox