pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniele Varrazzo <daniele.varrazzo@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Missing compiled default for channel_binding param from PQconndefaults
Date: Sun, 27 Dec 2020 20:48:45 -0500
Message-ID: <1536871.1609120125@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+mi_8Zo8Rgn7p+6ZRY7QdDu+23ukT9AvoHNyPbgKACxwgGhZA@mail.gmail.com>
References: <CA+mi_8Zo8Rgn7p+6ZRY7QdDu+23ukT9AvoHNyPbgKACxwgGhZA@mail.gmail.com>

Daniele Varrazzo <daniele.varrazzo@gmail.com> writes:
> compiled is expected to be "prefer" or "disable" as per docs.
> Please find a patch attached.

Yeah, that does look inconsistent, and I don't object to fixing
it.  But it's already the case that not all connection parameters
have defaults in that struct.  Isn't there a psycopg3 bug here
too, that it's not coping with a null default sanely?

I'm a bit suspicious that psycopg3 is expecting that NULL and
empty-string are equivalent for all parameters.  That is a convention
we upheld for a long time, but recent parameters have gotten away
from that --- not only channel_binding, but others such as sslmode.
If that's the underlying cause here then we need to think about
whether we want to restore that expectation.

			regards, tom lane





view thread (7+ messages)  latest in thread

Message-ID: <1536871.1609120125@sss.pgh.pa.us>
Permalink:  ../1536871.1609120125@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1536871.1609120125@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniele.varrazzo@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Missing compiled default for channel_binding param from PQconndefaults
  In-Reply-To: <1536871.1609120125@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox