From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Date: Wed, 09 Feb 2022 22:03:34 -0500
Message-ID: <1537890.1644462214@sss.pgh.pa.us> (raw)
In-Reply-To: <C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se>
References: <17391-304f81bcf724b58b@postgresql.org>
<20220202213900.h7paogmcge2rtls6@alap3.anarazel.de>
<CA+hUKGJ4+Ug16QU-PYGEZwUe2O69hdnCuyzLhMHHF02_uA4C5w@mail.gmail.com>
<131329.1643851912@sss.pgh.pa.us>
<203742.1643866877@sss.pgh.pa.us>
<C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
<887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
<621771.1644098845@sss.pgh.pa.us>
<635760.1644108785@sss.pgh.pa.us>
<1113966.1644280235@sss.pgh.pa.us>
<C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 8 Feb 2022, at 01:30, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> ..could we get away with ignoring EPIPE/ECONNRESET in writes during connection
>> startup? We'd notice the failure soon enough on the read side if it's not this
>> problem. (This seems a bit related to libpq's other hacks that postpone
>> recognition of write failures.)
> Off the cuff I can't think of a case where it would lead to adverse effects
> *during startup*.
Just to note that I have a plan for fixing this part. I've concluded
that it was a design error to implement the write_failed error
postponement mechanism in pqSendSome, and instead we should shove it
down a couple of abstraction layers into pqsecure_raw_write. This'd
visibly have no effect on non-encrypted connections, because
pqSendSome is the only caller of pqsecure_write. But in encrypted
connections, we'd be additionally allowing write-failure postponement
during OpenSSL's internal machinations, which seems to be exactly
what's wanted now that we have seen this failure mode.
There are some details to work through, but I hope to have a patch
soon.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, thomas.munro@gmail.com, andres@anarazel.de, pgsql-bugs@lists.postgresql.org, heikki.linnakangas@iki.fi, michael@paquier.xyz
Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
In-Reply-To: <1537890.1644462214@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox