pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry"
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2019-02-28 b3a156858a 0bf7f56cfe ab1d9f066a adb1f93e73 1e5ed16c61 00382f3732 Improve documentation of data_sync_retry
* BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry"
@ 2019-02-27 07:24 PG Bug reporting form <noreply@postgresql.org>
2019-02-28 02:05 ` Re: BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry" Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 2+ messages in thread
From: PG Bug reporting form @ 2019-02-27 07:24 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: thomas.poty@gmail.com
The following bug has been logged on the website:
Bug reference: 15659
Logged by: Thomas Poty
Email address: thomas.poty@gmail.com
PostgreSQL version: 10.7
Operating system: CentOS Linux release 7.4.1708 (Core)
Description:
In postgresql.conf, the mention of a required restart is missing for
"data_sync_retry" parameter :
- in the $PGDATA/postgresql.conf after an initdb
- in /usr/pgsql-10/share/postgresql.conf.sample
What I get :
#------------------------------------------------------------------------------
# ERROR HANDLING
#------------------------------------------------------------------------------
#exit_on_error = off # terminate session on any error?
#restart_after_crash = on # reinitialize after backend crash?
#data_sync_retry = off # retry or panic on failure to fsync data?
#------------------------------------------------------------------------------
What I should have :
#------------------------------------------------------------------------------
# ERROR HANDLING
#------------------------------------------------------------------------------
#exit_on_error = off # terminate session on any error?
#restart_after_crash = on # reinitialize after backend crash?
#data_sync_retry = off # retry or panic on failure to fsync data?
# (change requires restart)
#------------------------------------------------------------------------------
Information :
OS :
CentOS Linux release 7.4.1708 (Core)
Linux 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 20:13:58 UTC 2018 x86_64
x86_64 GNU/Linux
PostgreSQL version:
PostgreSQL 10.7 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 4.8.5 20150623
(Red Hat 4.8.5-36), 64-bit
PostgreSQL package installed :
https://download.postgresql.org/pub/repos/yum/10/redhat/rhel-7.4-x86_64/postgresql10-10.7-2PGDG.rhel...
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry"
2019-02-27 07:24 BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry" PG Bug reporting form <noreply@postgresql.org>
@ 2019-02-28 02:05 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2019-02-28 02:05 UTC (permalink / raw)
To: thomas.poty@gmail.com; pgsql-bugs@lists.postgresql.org
On Wed, Feb 27, 2019 at 07:24:39AM +0000, PG Bug reporting form wrote:
> In postgresql.conf, the mention of a required restart is missing for
> "data_sync_retry" parameter :
> - in the $PGDATA/postgresql.conf after an initdb
> - in /usr/pgsql-10/share/postgresql.conf.sample
You are right. I have noticed at the same time that the docs are
forgetting to mention the same and that the 80-character-limit was not
really respected, so fixed the whole and committed. There are other
places where that limit is not respected in postgresql.conf.sample,
particularly for the new recovery parameters... But well...
Thanks for the report!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-02-28 02:05 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 07:24 BUG #15659: missing comment "change requires restart" in postgresql.conf for parameter "data_sync_retry" PG Bug reporting form <noreply@postgresql.org>
2019-02-28 02:05 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox