From: Neil Chen <carpenter.nail.cz@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted
Date: Thu, 19 Nov 2020 08:20:18 +0000
Message-ID: <160577401827.18283.12544488614854285060.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CALT9ZEGD_QdW2n2_R5vhuxAES5OtvEdiZcp9QQBrPk298mwntA@mail.gmail.com>
References: <16663-fe97ccf9932fc800@postgresql.org>
<CALT9ZEGD_QdW2n2_R5vhuxAES5OtvEdiZcp9QQBrPk298mwntA@mail.gmail.com>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hi, I have tested the feature and it worked well.
One thing that doesn't matter is that the modify here seems unnecessary, right?
> mdunlinkfork(RelFileNodeBackend rnode, ForkNumber forkNum, bool isRedo)
> {
> char *path;
> - int ret;
> + int ret = 0;
> path = relpath(rnode, forkNum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: carpenter.nail.cz@gmail.com, pgsql-hackers@lists.postgresql.org, thomas.munro@gmail.com
Subject: Re: BUG #16663: DROP INDEX did not free up disk space: idle connection hold file marked as deleted
In-Reply-To: <160577401827.18283.12544488614854285060.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox