From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Japin Li <japinli@hotmail.com>
Cc: amutu@amutu.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
Date: Sat, 30 Sep 2023 20:44:07 -0400
Message-ID: <1615012.1696121047@sss.pgh.pa.us> (raw)
In-Reply-To: <ZRizujD8HMMpSXG5@paquier.xyz>
References: <18134-87126d90cb4dd049@postgresql.org>
<MEYP282MB1669351F137C61C19FA9749BB6C2A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
<ZRizujD8HMMpSXG5@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Sep 27, 2023 at 06:00:58PM +0800, Japin Li wrote:
>> It seems SaveResultVariables() was lost when executing failed. Attached fix it.
> Yeah, I think that you're right here, the variables should be set.
> SetResultVariables() ought to be called even if \gset failed to return
> a result.
Agreed. The adjacent comment is now a lie though. Maybe just
- /* set variables on last result if all went well */
+ /* set variables from last result */
Bigger-picture question: should we back-patch this, or just fix it in
HEAD? It's wrong, but I'm not sure it's so obviously wrong that there
could not be somebody depending on the existing behavior.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, japinli@hotmail.com, amutu@amutu.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18134: ROW_COUNT do not set to 0 when psql's \gset command get no rows returned
In-Reply-To: <1615012.1696121047@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox