From: Tom Lane <tgl@sss.pgh.pa.us>
To: bianpan2016@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15541: Use after release in PQprint
Date: Fri, 07 Dec 2018 13:02:30 -0500
Message-ID: <16265.1544205750@sss.pgh.pa.us> (raw)
In-Reply-To: <15915.1544205176@sss.pgh.pa.us>
References: <15541-c835d8b9a903f7ad@postgresql.org>
<15915.1544205176@sss.pgh.pa.us>
I wrote:
> Wow, that is ancient. It looks like commit edb519b14 of 27-Jul-1996
> added the pipe close stanza in the wrong place, and nobody's noticed
> it since. That's probably not so surprising given the multiple
> conditions required to trigger it plus the fact that this whole
> function is, if not completely dead code, at least not used anywhere
> in the PG distribution. Still, we oughta fix it.
Actually, looking closer at just what those conditions are: the
giant bit of spaghetti code at lines 177-188 will never enable the
pager if po->html3 is on. Probably that was because of laziness
about counting lines correctly in that case, but anyway it means
the problem situation is unreachable, AFAICS.
It still seems worth fixing in HEAD, in case anyone ever tries to
remove that restriction; but I'm no longer feeling that we need
to back-patch it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bianpan2016@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15541: Use after release in PQprint
In-Reply-To: <16265.1544205750@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox