From: Jeff Davis <pgsql@j-davis.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-bugs@postgresql.org, Robert Haas <robertmhaas@gmail.com>
Subject: Re: [16+] subscription can end up in inconsistent state
Date: Tue, 12 Sep 2023 13:33:57 -0700
Message-ID: <163428cd3f4bb3894ae86ed3278f320442ec41e1.camel@j-davis.com> (raw)
In-Reply-To: <CAA4eK1JC_wmBvfZuvimcmXuoG6LLKA5Xju5LAQDnJW_SfD-efA@mail.gmail.com>
References: <e5892973ae2a80a1a3e0266806640dae3c428100.camel@j-davis.com>
<CAA4eK1LJEMfdxpV7xDhR3qOFoSt3LuKbbu5kRMBfYJ2imT8Few@mail.gmail.com>
<5dff4caf26f45ce224a33a5e18e110b93a351b2f.camel@j-davis.com>
<CAA4eK1JC_wmBvfZuvimcmXuoG6LLKA5Xju5LAQDnJW_SfD-efA@mail.gmail.com>
On Tue, 2023-09-12 at 16:13 +0530, Amit Kapila wrote:
> Do we want to remove
> that as anyway, we will do that check via walrcv_connect()?
I think we should keep the DDL-time checks in place as a best-effort,
but not rely on them for security.
> Another point is that if we want to unify such a check at the time of
> walrcv_connect() then do we need to do it at the time of Alter
> Subscription? I think it will probably be better to catch the problem
> early
Agreed. Catching mistakes at DDL time is a better user experience.
> but does removing it from Alter Subscription time and doing it
> at connect time lead to security hazards?
We'd still be doing the same check, just later, right? If so there's
not a big security risk in removing the DDL-time checks. But it's
probably not a good idea to have non-superuser-owned subscriptions
without a password specified, so there may be some hazard there.
>
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: pgsql@j-davis.com, amit.kapila16@gmail.com, robertmhaas@gmail.com
Subject: Re: [16+] subscription can end up in inconsistent state
In-Reply-To: <163428cd3f4bb3894ae86ed3278f320442ec41e1.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox