pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Zsolt Ero <zsolt.ero@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Subject: Re: BUG #16604: pg_dump with --jobs breaks SSL connections
Date: Thu, 24 Sep 2020 12:11:36 -0400
Message-ID: <1638874.1600963896@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKw-smBKagNkWRZvTujeKgx6j5ZkjazDvDPFq9bZWbBC7YXqbg@mail.gmail.com>
References: <16604-933f4b8791227b15@postgresql.org>
	<61B1FFD2-EA7B-4C62-92A1-44C5459189C0@yesql.se>
	<CABUevEwwr=oCNQnu2RUTLhKwyKxRh3C__ckum=Xgm+acgUEJ_Q@mail.gmail.com>
	<CAKw-smBKagNkWRZvTujeKgx6j5ZkjazDvDPFq9bZWbBC7YXqbg@mail.gmail.com>

Zsolt Ero <zsolt.ero@gmail.com> writes:
>  I've created a minimal reproducible Dockerfile, it reproduces 100%. The PG
> server is configured to require client certificates.

I reproduced this locally, and the problem seems to be that
CloneArchive() is doing a far-less-than-half-baked job of
reconstructing the original connection parameters.
The data that PQconnectdbParams gets is just

(gdb) p keywords
$1 = {0x44ef22 "host", 0x44d52d "port", 0x44e4f0 "user", 0x4532b6 "password", 
  0x44ef14 "dbname", 0x45325f "fallback_application_name", 0x0}
(gdb) p values
$2 = {0x25459e0 "127.0.0.1", 0x25459a0 "5432", 0x2545180 "postgres", 0x0, 
  0x2a61d60 "dbname=regression", 0x2538410 "pg_dump", 0x0}

so parallel pg_dump is basically guaranteed to fail in any
case with even slightly unusual connection parameters.

Not sure why we should be trying to do it like that at
all; it'd be better if the original command-line parameters
got passed down in all cases.  Looking at that now.

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <1638874.1600963896@sss.pgh.pa.us>
Permalink:  ../1638874.1600963896@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1638874.1600963896@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, zsolt.ero@gmail.com, magnus@hagander.net, pgsql-bugs@lists.postgresql.org, daniel@yesql.se
  Subject: Re: BUG #16604: pg_dump with --jobs breaks SSL connections
  In-Reply-To: <1638874.1600963896@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox