From: Joe Conway <mail@joeconway.com>
To: Tristan Partin <tristan@neon.tech>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: gdo@leader.it
Cc: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
Date: Fri, 30 Jun 2023 08:13:10 -0400
Message-ID: <1645ebad-798f-87ad-43ac-72d2bf14d2d6@cd> (raw)
In-Reply-To: <CTPMCSM9UB07.3CUPU2JW4BBZ6@gonk>
References: <17946-3e84cb577e9551c3@postgresql.org>
<1564676.1685043220@sss.pgh.pa.us>
<555bb26e-c27c-ab65-028f-3fd5b82df9de@iki.fi>
<CTPMCSM9UB07.3CUPU2JW4BBZ6@gonk>
On 6/29/23 22:13, Tristan Partin wrote:
> On Mon Jun 5, 2023 at 11:00 AM CDT, Heikki Linnakangas wrote:
>> I think the uselocale() call renders ineffective the setlocale() calls
>> that we make later. Maybe we should replace our setlocale() calls with
>> uselocale(), too.
>
> For what it's worth to everyone else in the thread (especially Joe), I
> have a patch locally that fixes the mentioned bug using uselocale(). I
> am not sure that it is worth committing for v16 given how _large_ (the
> patch is actually quite small, +216 -235) of a change it is. I am going
> to spend tomorrow combing over it a bit more and evaluating other
> setlocale uses in the codebase.
(moving thread to hackers)
I don't see a patch attached -- how is it different than what I posted a
week ago and added to the commitfest here?
https://commitfest.postgresql.org/43/4413/
FWIW, if you are proposing replacing all uses of setlocale() with
uselocale() as Heikki suggested:
1/ I don't think that is pg16 material, and almost certainly not
back-patchable to earlier.
2/ It probably does not solve all of the identified issues caused by the
newer perl libraries by itself, i.e. I believe the patch posted to the
CF is still needed.
3/ I believe it is probably the right way to go for pg17+, but I would
love to hear opinions from Jeff Davis, Peter Eisentraut, and/or Thomas
Munroe (the locale code "usual suspects" ;-)), and others, about that.
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.comAttachments:
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: mail@joeconway.com, tristan@neon.tech, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, gdo@leader.it, pgsql-hackers@postgreSQL.org
Subject: Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG
In-Reply-To: <1645ebad-798f-87ad-43ac-72d2bf14d2d6@cd>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox