pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: robionekenobi@bluewin.ch
Subject: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
Date: Fri, 15 Jan 2021 07:48:31 +0000
Message-ID: <16825-c4f104bcebc67034@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      16825
Logged by:          Robert Grange
Email address:      robionekenobi@bluewin.ch
PostgreSQL version: 13.1
Operating system:   Windows
Description:        

Hi,

in src\tools\msvc\Solution.pm the following test is not sufficient
		$self->{platform} =
		  ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : 'Win32';
because the cl /? returns:
		Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29336 for x64
		Copyright (C) Microsoft Corporation.  All rights reserved.

better to check like this ?
		$self->{platform} =
		  ($output =~ /^\/favor:<.+AMD64/m) ? 'x64' : ($output =~ /.x64$/m) ?
'x64' : 'Win32';

Regards
Robert



view thread (11+ messages)  latest in thread

Message-ID: <16825-c4f104bcebc67034@postgresql.org>
Permalink:  ../16825-c4f104bcebc67034@postgresql.org/
Also on:    postgresql.org/message-id/16825-c4f104bcebc67034@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, pgsql-bugs@lists.postgresql.org, robionekenobi@bluewin.ch
  Subject: Re: BUG #16825: When building on Windows, cl /? retrun 'x64' not AMD64 and the build does not create x64 environment
  In-Reply-To: <16825-c4f104bcebc67034@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox