pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: hghwng@gmail.com, pgsql-bugs@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
Date: Mon, 30 Mar 2020 11:35:41 -0400
Message-ID: <17009.1585582541@sss.pgh.pa.us> (raw)
In-Reply-To: <20200330071937.GC43995@paquier.xyz>
References: <16330-b34835d83619e25d@postgresql.org>
	<20200330071937.GC43995@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Mar 30, 2020 at 02:20:48AM +0000, PG Bug reporting form wrote:
>> If the connection to postmaster is closed, then trying to re-connect to
>> another one leads to SIGSEGV.

> A fix like the attached should be sufficient as if we know that
> PQhost() is NULL for the old connection we cannot use the old
> hostaddr.  Alvaro, what do you think?

It looks to me like there's a similar hazard a bit further down
(line 3029):

		appendConnStrVal(&connstr, PQdb(o_conn));

I wonder if we should force reuse_previous to false if there's
no o_conn, rather than fixing this stuff piecemeal.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <17009.1585582541@sss.pgh.pa.us>
Permalink:  ../17009.1585582541@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17009.1585582541@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@2ndquadrant.com
  Subject: Re: BUG #16330: psql accesses null pointer in connect.c:do_connect
  In-Reply-To: <17009.1585582541@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox