From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Tender Wang <tndrwang@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18422: Assert in expandTupleDesc() fails on row mismatch with additional SRF
Date: Thu, 11 Apr 2024 10:13:15 -0400
Message-ID: <170712.1712844795@sss.pgh.pa.us> (raw)
In-Reply-To: <CAMbWs4_QgZogwYUgXb=7K_GQ-w2JC3JxONZygkQiXBu11CyXCQ@mail.gmail.com>
References: <18422-89ca86c8eac5246d@postgresql.org>
<CAHewXNkfDfKw80kgNvtC0ZvNz=hGxXLyEwiGJzhr3r_fFAkVeQ@mail.gmail.com>
<3861246.1712691263@sss.pgh.pa.us>
<CAMbWs4-3O34h5_T_OXRsAzGKg+cQEp1w9aq5i=U3EbxQzvo5VA@mail.gmail.com>
<3917908.1712719937@sss.pgh.pa.us>
<CAMbWs4_j1wq+nUK4t1oROOj2Qgvds=3G4RWA3NBNygf1wkha0A@mail.gmail.com>
<4019337.1712758601@sss.pgh.pa.us>
<CAMbWs4_QgZogwYUgXb=7K_GQ-w2JC3JxONZygkQiXBu11CyXCQ@mail.gmail.com>
Richard Guo <guofenglinux@gmail.com> writes:
> On Wed, Apr 10, 2024 at 10:16 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Wilco. Another thing I was considering, but didn't pull the trigger
>> on in the draft patch, was to introduce a funcapi.c function on the
>> order of
>> get_expr_result_rtfunc(RangeTblFunction *rtfunc, ...)
>> which would encapsulate applying either BuildDescFromLists or
>> get_expr_result_type.
> Do you think we can have a parameter in the new get_expr_result_rtfunc()
> function to indicate whether we want to build an intermediate tupdesc
> when we have a coldeflist? Then we can set it to true in the two places
> that are correct already, and set it to false at the places we need to
> fix. But I'm not sure if including such a new parameter would be an
> improvement or just make it worse.
I did think about that, but it seems mighty weird. The semantics of
the flag would have to be something like "I want a tupdesc when the
result type is COMPOSITE, but not when it's RECORD", which seems
rather arbitrary.
Perhaps it'd be sufficient to add a note to the header comment of
get_expr_result_type warning about when not to use it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, guofenglinux@gmail.com, tndrwang@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18422: Assert in expandTupleDesc() fails on row mismatch with additional SRF
In-Reply-To: <170712.1712844795@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox