From: Pierre Forstmann <pierre.forstmann@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Subject: Re: BUG #19631: currtid2() on a view with GROUP BY ctid crashes with XX000
Date: Sat, 12 Sep 2026 09:15:11 +0000
Message-ID: <178920451166.1175.1908642259509647383.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CAJTYsWVYYpxOx29jxrR4SzYMGzJtENr4iQ53NvVE3uzCFtVkrQ@mail.gmail.com>
References: <19631-b443dd6cd8d4e40b@postgresql.org>
<CAJTYsWVYYpxOx29jxrR4SzYMGzJtENr4iQ53NvVE3uzCFtVkrQ@mail.gmail.com>
Hello,
I think that the that SQLSTATE chosen in unicode_assigned() is wrong: this not a SQL statement syntax error but more a feature not supported for the current database encoding;
ERRCODE_FEATURE_NOT_SUPPORTED is more appropriate.
Maybe you could add a regression test for tid.c ?
Other modifications look good to me and more difficult to test automatically.
Regards,
PF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: pierre.forstmann@gmail.com, pgsql-hackers@lists.postgresql.org, ayushtiwari.slg01@gmail.com
Subject: Re: BUG #19631: currtid2() on a view with GROUP BY ctid crashes with XX000
In-Reply-To: <178920451166.1175.1908642259509647383.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox