From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16037: Assertion fails in varbit_out
Date: Fri, 04 Oct 2019 01:52:07 -0400
Message-ID: <18353.1570168327@sss.pgh.pa.us> (raw)
In-Reply-To: <20191004054241.x4cfcu4qnaucggf3@alap3.anarazel.de>
References: <16037-1d1ebca564db54f4@postgresql.org>
<17708.1570167288@sss.pgh.pa.us>
<20191004054241.x4cfcu4qnaucggf3@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-10-04 01:34:48 -0400, Tom Lane wrote:
>> D'oh ... bitshiftright() needs to do the zero-pad-fixup in both
>> code paths. Will fix it tomorrow.
> Does that suggest we shouldn't make the asserts active in the branches <
> 12?
No, it just means the previous patch was an incomplete fix. The
whole point of the asserts was to flush out cases where we weren't
padding correctly, and they just did that :-)
(Besides which, we discourage people from running with asserts on
in production, so I don't quite see what your concern is.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16037: Assertion fails in varbit_out
In-Reply-To: <18353.1570168327@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox