From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: dacherny@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16631: postgres_fdw tries to insert into generated columns
Date: Wed, 07 Jul 2021 11:54:19 -0400
Message-ID: <1838679.1625673259@sss.pgh.pa.us> (raw)
In-Reply-To: <8a61d9c4-b614-e2dc-6bcc-bfc17db4d2f9@enterprisedb.com>
References: <16631-e929fe9db0ffc7cf@postgresql.org>
<CAPmGK15BvXLPJQ7K9Pvq7mkeP3tSuuqU=pPJA1dUrsayrhzoiw@mail.gmail.com>
<CAPmGK173z88dS-us68jm-3ynscYdSK=mnUpiO3pOTBP_5S=AFQ@mail.gmail.com>
<8a61d9c4-b614-e2dc-6bcc-bfc17db4d2f9@enterprisedb.com>
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 07.07.21 09:20, Etsuro Fujita wrote:
>> * Modified nodeModifyTable.c and copyfrom.c so that they don't compute
>> generated columns for FDWs anymore.
> I don't agree with that change. What is the point of declaring a
> generated column on a foreign table if you ignore it? Then you might as
> well prohibit declaring such columns in the first place.
Maybe what we need here is some documentation clarifying exactly what
the point of a generated column on a foreign table actually *is*.
When would you do it, and what relationship if any has it got to the
generation status of the underlying remote column?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, etsuro.fujita@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16631: postgres_fdw tries to insert into generated columns
In-Reply-To: <1838679.1625673259@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox