pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Laetitia Avrot <laetitia.avrot@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Japin Li <japinli@hotmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Statistics updates is delayed when using `commit and chain`
Date: Mon, 01 Aug 2022 12:25:58 -0400
Message-ID: <1839632.1659371158@sss.pgh.pa.us> (raw)
In-Reply-To: <20220801161256.ogcacmw6txiecvfb@awork3.anarazel.de>
References: <MEYP282MB1669840B952A11A638AEAA67B6139@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
	<3453636.1626232720@sss.pgh.pa.us>
	<CAKFQuwYnpkDkeKHh7xwMAUqarcYiw9QDg8+Umz7THmEbCH7SzA@mail.gmail.com>
	<3455196.1626234760@sss.pgh.pa.us>
	<CAKFQuwaTDMYW0v2cv+CxLfnyJ_OAh=Pc0YKvD8f3xc3DtB_LHQ@mail.gmail.com>
	<CAKFQuwZSi6vWEUtZKQhqzHj8FeWtgon=HJ-BGLfpRwjErpwKGw@mail.gmail.com>
	<MEYP282MB16691F2B962B05BB1AC5C151B6139@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
	<CAB_COdjhzA+9URWOekr3s=J-+kMsUQDcjae2rF00Z5X-jDKzuA@mail.gmail.com>
	<MEYP282MB16691A6E80DF769F04BF9EB0B6E99@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
	<CAB_COdiHgHsUb7qxftTe9S-fagXr3Xv+Grw5rcdjwvu2pYy1uA@mail.gmail.com>
	<20220801161256.ogcacmw6txiecvfb@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> I don't like copying the same comment etc into multiple places. Given the
> number of identical blocks for if (s->chain) blocks, perhaps we should just
> move it into a new helper?

What I suggested a few days ago is that it should be in CommitTransaction.

			regards, tom lane





view thread (29+ messages)  latest in thread

Message-ID: <1839632.1659371158@sss.pgh.pa.us>
Permalink:  ../1839632.1659371158@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1839632.1659371158@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, laetitia.avrot@gmail.com, peter@eisentraut.org, japinli@hotmail.com, david.g.johnston@gmail.com, john.naylor@enterprisedb.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: Statistics updates is delayed when using `commit and chain`
  In-Reply-To: <1839632.1659371158@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox