pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: bastian.thierry@laposte.net
Subject: BUG #18672: failing to link postgresql
Date: Thu, 24 Oct 2024 18:35:12 +0000
Message-ID: <18672-66509a1043077366@postgresql.org> (raw)

The following bug has been logged on the website:

Bug reference:      18672
Logged by:          Thierry Bastian
Email address:      bastian.thierry@laposte.net
PostgreSQL version: 16.4
Operating system:   macOS
Description:        

In short, in src/interfaces/libpq/Makefile there is a check for lib-a to not
contain a call to exit. But the issue is that on macOS, it still uses
_atexit and pthread_exitm which are fine.
My fix to this is to apply the following patch:

inline patch 1: src/interfaces/libpq/Makefile (+1/-1 lines) download inline-1.patch
diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index 0919d8f..65b07d3 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -118,7 +118,7 @@ backend_src = $(top_srcdir)/src/backend
 libpq-refs-stamp: $(shlib)
 ifneq ($(enable_coverage), yes)
 ifeq (,$(filter aix solaris,$(PORTNAME)))
-	@if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep exit; then \
+	@if nm -A -u $< 2>/dev/null | grep -v __cxa_atexit | grep -v _atexit |
grep -v pthread_exit | grep exit; then \
 		echo 'libpq must not be calling any function which invokes exit'; exit 1;
\
 	fi
 endif

view thread (3+ messages)  latest in thread

Message-ID: <18672-66509a1043077366@postgresql.org>
Permalink:  ../18672-66509a1043077366@postgresql.org/
Also on:    postgresql.org/message-id/18672-66509a1043077366@postgresql.org

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noreply@postgresql.org, pgsql-bugs@lists.postgresql.org, bastian.thierry@laposte.net
  Subject: Re: BUG #18672: failing to link postgresql
  In-Reply-To: <18672-66509a1043077366@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox