From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: sbernikov@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
Date: Fri, 11 Jun 2021 11:01:07 -0400
Message-ID: <1881335.1623423667@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
References: <17055-9ba800ec8522668b@postgresql.org>
<1828113.1623370641@sss.pgh.pa.us>
<CA+HiwqG05LNWKv=fJDtF93LFmA99KCSZtnAJUAsjBOLFOPy-fA@mail.gmail.com>
<YMMCFPuQwO6sEcJ+@paquier.xyz>
<CA+HiwqF0xi2KmPYKPPCtcgQ2vnjQrfm5cdY50VRC+S_s1M4KvQ@mail.gmail.com>
Amit Langote <amitlangote09@gmail.com> writes:
> On Fri, Jun 11, 2021 at 3:26 PM Michael Paquier <michael@paquier.xyz> wrote:
>> It seems to me that it would make sense to have some coverage. We've
>> caught issues in the past in this area, particularly with buildfarm
>> animals running CLOBBER_CACHE_ALWAYS.
> I thought about it for a minute when writing the patch I posted, but
> wasn't really sure what the test case would look like. The only
> external proof that the case worked correctly, AFAICS, is the DEBUG1
> message that's written to the log. How do we add a test case with
> that? I know you mentioned an idea before to check/grep the log for
> such cases. Is that how?
I see from the coverage report that *none* of the did-not-find-tuple
code paths in worker.c are exercised. This does not seem OK. I agree
that probably the only way to have a test case is to kick up the debug
level to DEBUG1 and grep the log to confirm that the message is there.
IIRC, we already have infrastructure for grepping the log, so this
shouldn't be that hard. Will work on it today.
(Meanwhile, thanks for the diagnosis and patch!)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17055: Logical replication worker crashes when applying update of row that dose not exist in target partiti
In-Reply-To: <1881335.1623423667@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox